Expose deploy inputs and pin staging/prod images#87
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughUpdated GitHub Actions workflows to add a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the deployment configuration to make staging/production workflow dispatches more configurable (runner backend + optional clean install) and pins critical staging/production images to a specific tag for reproducibility.
Changes:
- Pin staging/production Theia Cloud operator/service images and CRD conversion-webhook image to
latest-dfe0d09. - Expose
execution_modeas a workflow_dispatch choice input in staging/production deploy workflows. - Add
clean_installworkflow_dispatch input to staging/production deploy workflows and default PR deployclean_installtotrue.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deployments/theia.artemis.cit.tum.de/values.yaml | Pins operator/service images and explicitly configures service admin API token secret for production. |
| deployments/theia.artemis.cit.tum.de/theia-crds-helm-values.yml | Pins conversion-webhook image for production CRDs install. |
| deployments/theia-staging.artemis.cit.tum.de/values.yaml | Pins operator/service images and explicitly configures service admin API token secret for staging. |
| deployments/theia-staging.artemis.cit.tum.de/theia-crds-helm-values.yml | Pins conversion-webhook image for staging CRDs install. |
| .github/workflows/deploy-staging.yml | Adds execution_mode choice + clean_install boolean input and forwards clean_install to reusable deploy workflow. |
| .github/workflows/deploy-production.yml | Adds execution_mode choice + clean_install boolean input and forwards clean_install to reusable deploy workflow. |
| .github/workflows/deploy-pr.yml | Changes workflow_dispatch default for clean_install to true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukaskratzel
left a comment
lukaskratzel
left a comment
There was a problem hiding this comment.
LGTM. Could you please document the new release process though as that now requires bumping the short sha in the tag. Would be nice for everyone after us :)
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
deployments/test1.theia-test.artemis.cit.tum.de/theia-crds-helm-values.yml (1)
5-5: Prefer immutable image tags for reproducible test deployments.Using
:lateston Line 5 can make test behavior drift between runs and make regressions harder to bisect. Consider pinning to a release tag (or digest) and bumping intentionally.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deployments/test1.theia-test.artemis.cit.tum.de/theia-crds-helm-values.yml` at line 5, The image field currently uses a mutable tag "ghcr.io/eduide/eduide-cloud/conversion-webhook:latest"; change the image value under the image key to a specific immutable tag or digest (for example a release tag like :v1.2.3 or a SHA256 digest) so test deployments are reproducible and upgrades are explicit; update the image string in the YAML (the image key holding "ghcr.io/eduide/eduide-cloud/conversion-webhook:latest") to the chosen pinned tag/digest and bump it intentionally on future changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@deployments/test1.theia-test.artemis.cit.tum.de/theia-crds-helm-values.yml`:
- Line 5: The image field currently uses a mutable tag
"ghcr.io/eduide/eduide-cloud/conversion-webhook:latest"; change the image value
under the image key to a specific immutable tag or digest (for example a release
tag like :v1.2.3 or a SHA256 digest) so test deployments are reproducible and
upgrades are explicit; update the image string in the YAML (the image key
holding "ghcr.io/eduide/eduide-cloud/conversion-webhook:latest") to the chosen
pinned tag/digest and bump it intentionally on future changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e076204d-3662-48c4-b272-514bae0ea3e4
📒 Files selected for processing (12)
.github/workflows/deploy-pr.yml.github/workflows/deploy-production.yml.github/workflows/deploy-staging.ymlREADME.mddeployments/test1.theia-test.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/test2.theia-test.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/test3.theia-test.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/theia-staging.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/theia-staging.artemis.cit.tum.de/values.yamldeployments/theia.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/theia.artemis.cit.tum.de/values.yamldocs/deployment-workflows.md
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
This PR aligns deployment workflow inputs, updates pinned image tags across environments, and documents the new release process for SHA-suffixed image tags.
Changes made
execution_modein staging and productionworkflow_dispatchwith the same dropdown options used by the PR workflow:self-hosted-buildkitgithub-runnersclean_installas a manual input for staging and production deploy workflowsclean_installopt-in and passed it through to the reusable deploy workflowclean_installnow defaults totrueoperatorandserviceimages toghcr.io/eduide/eduide-cloud/*:latest-dfe0d09operatorandserviceimages toghcr.io/eduide/eduide-cloud/*:latest-dfe0d09conversion-webhooktoghcr.io/eduide/eduide-cloud/conversion-webhook:latest-dfe0d09conversion-webhooktoghcr.io/eduide/eduide-cloud/conversion-webhook:latest-dfe0d09conversion-webhooktags frompr-70tolatestfor:test1test2test3latest-2c6f8ac:theia-cloud.landingPage.imagetheia-cloud.preloading.images[0]latest-2c6f8ac:theia-cloud.landingPage.imagetheia-cloud.preloading.images[0]latest-0c8eec9:theia-cloud.preloading.images[1..10]latest-0c8eec9:theia-cloud.preloading.images[1..10]docs/deployment-workflows.mdwith:README.mdto document the pinned-tag release process and link to the deployment workflow guideFiles touched
.github/workflows/deploy-pr.yml.github/workflows/deploy-staging.yml.github/workflows/deploy-production.ymldeployments/theia-staging.artemis.cit.tum.de/values.yamldeployments/theia-staging.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/theia.artemis.cit.tum.de/values.yamldeployments/theia.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/test1.theia-test.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/test2.theia-test.artemis.cit.tum.de/theia-crds-helm-values.ymldeployments/test3.theia-test.artemis.cit.tum.de/theia-crds-helm-values.ymldocs/deployment-workflows.mdREADME.mdValidation