Skip to content

Feat/bazel#35

Merged
KevinGruber2001 merged 6 commits intomainfrom
feat/bazel
Mar 27, 2026
Merged

Feat/bazel#35
KevinGruber2001 merged 6 commits intomainfrom
feat/bazel

Conversation

@KevinGruber2001
Copy link
Copy Markdown
Collaborator

@KevinGruber2001 KevinGruber2001 commented Mar 27, 2026

Summary by CodeRabbit

  • New Features

    • Added Prometheus monitoring support with configurable ServiceMonitor resources for cache server and Reposilite.
    • Enhanced Reposilite configuration with configurable proxy repositories and improved secret management.
  • Chores

    • Rebranded Helm chart from "theia-shared-cache" to "eduide-shared-cache" with version bump to 0.5.0.
    • Updated container image repository references.
    • Restructured Kubernetes resource naming and configuration organization.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ca7dbd39-beca-48c9-9dbd-56dd0ef8f557

📥 Commits

Reviewing files that changed from the base of the PR and between 92984f3 and caf3e6a.

📒 Files selected for processing (17)
  • .github/workflows/chart-preview.yml
  • .github/workflows/docker-build.yml
  • .github/workflows/release.yml
  • chart/Chart.yaml
  • chart/templates/_helpers.tpl
  • chart/templates/auth-secrets.yaml
  • chart/templates/configmap.yaml
  • chart/templates/deployment.yaml
  • chart/templates/redis-deployment.yaml
  • chart/templates/redis-secret.yaml
  • chart/templates/redis-service.yaml
  • chart/templates/reposilite-secret.yaml
  • chart/templates/reposilite-shared-config.yaml
  • chart/templates/service.yaml
  • chart/templates/servicemonitor-cache.yaml
  • chart/templates/servicemonitor-reposilite.yaml
  • chart/values.yaml

📝 Walkthrough

Walkthrough

This pull request performs a comprehensive rebranding from theia-shared-cache to eduide-shared-cache across GitHub workflows and Helm chart metadata, updates the container image repository, bumps chart version to 0.5.0, refactors resource naming from Release.Name to Chart.Name, introduces Prometheus ServiceMonitor templates, and adds Reposilite secret management infrastructure.

Changes

Cohort / File(s) Summary
GitHub Workflows
.github/workflows/chart-preview.yml, docker-build.yml, release.yml
Updated artifact naming from theia-shared-cache to eduide-shared-cache in all workflows; Docker build workflow adds conditional chart path triggers, unconditional registry login, version-based tagging from Chart.yaml with PR suffix, and always-push behavior.
Helm Chart Metadata & Helpers
chart/Chart.yaml, chart/templates/_helpers.tpl
Renamed chart from theia-shared-cache to eduide-shared-cache, bumped version to 0.5.0, removed appVersion field; updated template helper definitions and removed app.kubernetes.io/version label from generated labels.
Helm Secret & Authorization Templates
chart/templates/auth-secrets.yaml, redis-secret.yaml, reposilite-secret.yaml
Updated Secret naming from Release.Name to Chart.Name; added new reposilite-secret template with conditional creation and random password generation for Prometheus credentials; adjusted label references.
Helm Service & Networking Templates
chart/templates/redis-service.yaml, service.yaml
Changed Service names from Release.Name to Chart.Name; updated label helper references from theia-shared-cache to eduide-shared-cache.
Helm Resource Deployment Templates
chart/templates/configmap.yaml, deployment.yaml, redis-deployment.yaml
Switched resource naming from Release.Name to Chart.Name across metadata, selectors, and references; adjusted label helpers and resource path references; changed image tag default handling and resource configuration structure.
Helm Monitoring Templates
chart/templates/servicemonitor-cache.yaml, servicemonitor-reposilite.yaml
Added two new conditional ServiceMonitor templates for Prometheus integration: one targeting cache-server pods and one targeting reposilite with basicAuth sourced from secrets.
Helm Configuration Templates
chart/templates/reposilite-shared-config.yaml
Updated label helper reference; replaced hardcoded Maven/Gradle proxy repositories with Helm-driven list from .Values.reposilite.proxyRepositories.
Helm Values Configuration
chart/values.yaml
Updated image repository to ghcr.io/eduide/eduide-shared-cache/gradle-cache and tag handling; reorganized resource blocks (moved redis resources to dedicated redis.resources); added monitoring.enabled flag; added Reposilite adminToken and proxyRepositories config; migrated Reposilite credentials from hardcoded to secret-backed environment variables.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • add pr based chart releases #24 — Overlaps on Helm chart and CI workflow modifications with similar concerns around chart configuration and registry handling.
  • add to gci and minor improvements #29 — Shares GitHub workflow file changes (chart-preview.yml, release.yml) for OCI/registry artifact management and chart naming updates.
  • Fix helm chart #15 — Modifies overlapping Helm chart templates (configmap.yaml, deployment.yaml) and resource naming/values rendering logic.

Poem

🐰 A tale of names reborn today,
From Theia's cache to EduIDE's way,
Chart names dance, resources align,
With Prometheus watchful, secrets combine,
Our burrow's refactored—clean and bright! 🌟

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/bazel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KevinGruber2001 KevinGruber2001 merged commit 60e44b1 into main Mar 27, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown

Chart Preview Ready

helm install test oci://ghcr.io/eduide/charts/eduide-shared-cache --version 0.5.0-pr.35

Updated: 4c404f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant