chore(landing): remove dead dashboard-shell component cluster - #408
chore(landing): remove dead dashboard-shell component cluster#408EfeDurmaz16 wants to merge 2 commits into
Conversation
app-shell.tsx and the components it composed (app-sidebar, app-header, command-palette, keyboard-shortcuts), plus empty-state and page-transition, were dashboard-template scaffolding imported by nothing — the marketing pages use inline-styled layouts. ~1.3k LOC of dead code; verified no remaining references. (framer-motion is now unused; left for a follow-up that also prunes the now-dead ui/ primitives.)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 660e7d281a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| Use `sardis_spend` only after a successful `sardis_check_policy` result. | ||
|
|
||
| Use `sardis_pay_invoice` for invoice-shaped requests instead of manually constructing a payment when invoice metadata is available. |
There was a problem hiding this comment.
When the request includes invoice metadata, this tells the agent to call sardis_pay_invoice, but the explicit preflight rule above only applies to sardis_spend. In the actual tool surface, sardis_pay_invoice is a money-moving path (payments.executeMandate or client.pay(...) in packages/sardis-agent-tools/src/tools/verbs.ts:186-201) and is classified alongside sardis_spend (packages/sardis-agent-tools/src/classify.ts:55-62), so under-threshold invoice payments can skip the sardis_check_policy step in the exact invoice flow this skill recommends.
Useful? React with 👍 / 👎.
1 participant
Removes
app-shell.tsxand the components it composed (app-sidebar, app-header, command-palette, keyboard-shortcuts) plus empty-state and page-transition — dashboard-template scaffolding imported by nothing (~1.3k LOC). Verified zero references across app/ and components/.From the ponytail×deslop minimization audit.
framer-motion(now unused) and the now-deadcomponents/ui/primitives are left for a careful follow-up (the ui prune needs verification beyond grep).