chore(contracts): remove deprecated SardisVerifyingPaymaster - #410
chore(contracts): remove deprecated SardisVerifyingPaymaster#410EfeDurmaz16 wants to merge 2 commits into
Conversation
SardisVerifyingPaymaster.sol is marked DEPRECATED / "do NOT deploy to mainnet" in-file — superseded by Circle Paymaster (permissionless, no deployment needed). No contract, script, or test references it. Remove it and its test, and drop the stale mention from the ReentrantToken mock comment. forge build clean.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed9686d60d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| Use `sardis_spend` only after a successful `sardis_check_policy` result. | ||
|
|
||
| Use `sardis_pay_invoice` for invoice-shaped requests instead of manually constructing a payment when invoice metadata is available. |
There was a problem hiding this comment.
Require policy checks before invoice payments
For invoice-shaped requests, this tells OpenClaw agents to call sardis_pay_invoice directly, while the only explicit policy gate above is scoped to sardis_spend. When an invoice has a recipient/amount but no already-approved mandate, an agent can follow this skill and initiate the invoice payment without the sardis_check_policy dry run required for normal spends; require the same successful policy result, or a validated mandate, before the invoice path proceeds.
Useful? React with 👍 / 👎.
SardisVerifyingPaymaster.solis marked DEPRECATED / "do NOT deploy to mainnet" in-file — superseded by Circle Paymaster (permissionless, no deployment). No contract, script, or test references it. Removes it and its test, and drops the stale mention from the ReentrantToken mock comment (ReentrantToken stays — used by RefundProtocol tests).forge buildclean.