-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix(dashboard): auto-expand small containers on layer navigation #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Muammer06
wants to merge
5
commits into
Egonex-AI:main
Choose a base branch
from
Muammer06:fix/dashboard-auto-expand-collapsed-containers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0f54eec
fix(dashboard): auto-expand small containers on layer navigation
Muammer06 a5b0038
chore: add PNG diagrams for PR #492
Muammer06 086b205
Revert "chore: add PNG diagrams for PR #492"
Muammer06 935b6ec
chore: remove diagram assets from feature branch (hosted on docs branch)
Muammer06 33b42d8
fix(dashboard): guard auto-expand against stale topology on layer switch
Muammer06 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When navigating directly from one detail layer to another (for example via a portal or tour step),
topo.containersstill holds the previous layer until the async Stage 1 layout callssetTopology. This effect runs immediately on theactiveLayerIdchange, records the new layer as already auto-expanded, and then filters/expands stale container ids; once the real topology arrives the guard skips the layer, so small containers are not auto-expanded, and colliding ids can even expand a large container based on the previous layer’s child count. Gate this on fresh topology/layout for the current layer before adding it toautoExpandedLayersRef.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and fixed in 33b42d8.
Root cause:
containers/containerIds/nodesall derive from the sametopotopology state, so on a direct layer→layer jump (portal/tour, wherenavigationLevelstays"layer-detail") they hold the previous layer for one flush until the async Stage 1 ELK callssetTopology. The effect ran in that window, added the newactiveLayerIdtoautoExpandedLayersRef, and expanded stale ids — so once fresh topology arrived thehas(activeLayerId)guard skipped the layer and its small containers never expanded.This staleness window was already known: the sibling
fitVieweffect bails on it vianewLayoutRef. The fix applies the same guard before mutating the ref:When ELK completes,
newLayoutRefclears andsetTopologyre-renders → the effect re-runs with freshcontainersand marks/expands the layer correctly.