-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling additions #1
base: master
Are you sure you want to change the base?
Conversation
… will fill all remaining space
…evices supporting that feature
Hello Dominik, very good improvements. I like your suggestions to move info and control buttons to the navbar, also is that very good idea to use icons and stylesheet offline. I have to check how to merge your changes with my uncommitted changes. Maybe also good idea for me to implement your features manually to better understand your code changes :) Style stuff is not really what I can. Maybe I can learn something |
To be honest, styling is also not something I really like nor am good at, but I had to deal with bootstrap in small html/css projects before, so I was familiar with one of the basic ideas in bootstrap (https://getbootstrap.com/docs/5.0/layout/grid/) But I've never used dash before, so I mostly added the classes to |
I changed in the app.py seems to be working |
Suggetions from pull-request: #1
- The bootstrap themes are not more loaded from CDN - Theme is available offline - Suggestion from pull-request: #1 Thanks to user Frischid!!!
- Component simple navbar replaced through navbar - Remote control and infobox button moved out to navbar to reduce amount of clicks - Sugestion from pul-request: #1 - Thanks to user Frischid!!!
That's perfect, wasn't aware of |
Hello Dominik, I implemented almost changes from your pull request. I think just changing to doc.Containers is open. But now I see one problem, I can't scroll content in browser (just saw it on mobile safari, don't if other browsers also affected). Do you know what could be a problem? |
Ok, I got it! |
Hi Alexander, |
Hallo, |
Hi @EinEinfach,
first of all, thank you very much for this great app, it's awesome.
I had some spare time but no access to our mower, so I implemented some ideas to improve some parts (in my opinion).
If you don't like them just ignore or close the merge request.
title
attributes to the button which are displayed as tooltipAll the additions are mainly styling and personal, if you don't like them that's fine, I won't be mad at you :)