-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to three.js #11
base: master
Are you sure you want to change the base?
Conversation
Awesome! Very responsive, and the structure looks much better than what we had before. I'd like to add mouse panning and do a couple tests before merging it into master, but this is great! |
You can mouse panning using right click |
I found a bug, when you pann the reset view button doesn't work as expected, I am working on this |
done |
Right-click panning works in Firefox and Chromium for me in e7bc1d5. Reset view after right-click panning works on both. Also feels much speedier, those this.controls.reset() additions helped! :) |
Rotation and panning with the mouse is very sluggish for me on Chrome (firefox seems fine). |
Zooming has also slowed down on both firefox and chrome (I have to turn the mouse wheel a lot more to achieve the same amount of zoom). On Chrome, it is slow enough to be very frustrating. |
Even blockly has reduced performance for me on chrome, which makes no sense. Dragging blocks around is more sluggish than it used to be. |
three.js and lightgl.js are very diferent, three.js keeps a complete scene graph so it is more resource hungry than lightgl, I have interest in using three.js to implement mouse interaction in the scene, like selecting objects, animation and assembly. I think performance can be improved but a bigger library like three.js have some performance drawbacks that needs to be addressed. |
I am sorry, I accidentally clicked close |
I was interested in using three.js for being able to set transparency of objects. But Blockly performance in chrome is pretty bad in the current state. |
The original grid size was 20x20, the workspace volume now is 15 times larger than before, that maybe causes a big performance difference, I will decreased to 20x20 |
Confirming crazy-high CPU usage in 031f5e0, using Chromium 45.0.2454.85 Ubuntu 14.04 (64-bit). 100% of a core without even rendering anything. Not seeing the blockly performance issues, but I'm guessing they're tied to the CPU usage. |
yes I see it now, I will work on that |
viewer.js was heavily modified and renamed to threeViewer.js, files three.min.js, OrbitControls.js were included, lightgl.js was deleted, blockscad_build.py was modified to include these changes.
the 3d view looks indentical to the previous one with better touch respose tested on firefox on a old (2012 version) galaxy note 10.1.