fix: respect host and protocol options in vite_preload_tag (#413)

* Respect host and protocol options in vite_preload_tag When specifying the host and protocol options for a vite_javascript_tag we want the preload tags to also respect those options. * chore: use `extract!` instead --------- Co-authored-by: Maximo Mussini <[email protected]>
ElMassimo · Nov 5, 2024 · bcd8151 · bcd8151
1 parent 57a6e7a
commit bcd8151
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/test/helper_test.rb b/test/helper_test.rb
@@ -105,6 +105,14 @@ def test_vite_stylesheet_tag
     }
   end
 
+  def test_vite_preload_tag
+    assert_includes vite_typescript_tag('main', host: 'example.com', protocol: 'https'), [
+      %(<link rel="modulepreload" href="https://example.com/vite-production/assets/log.818edfb8.js" as="script" crossorigin="anonymous">),
+      %(<link rel="modulepreload" href="https://example.com/vite-production/assets/vue.3002ada6.js" as="script" crossorigin="anonymous">),
+      %(<link rel="modulepreload" href="https://example.com/vite-production/assets/vendor.0f7c0ec3.js" as="script" crossorigin="anonymous">),
+    ].join("\n")
+  end
+
   def test_vite_javascript_tag
     assert_similar [
       %(<script src="/vite-production/assets/main.9dcad042.js" crossorigin="anonymous" type="module"></script>),

diff --git a/vite_rails/lib/vite_rails/tag_helpers.rb b/vite_rails/lib/vite_rails/tag_helpers.rb
@@ -101,7 +101,8 @@ def vite_manifest
 
   # Internal: Renders a modulepreload link tag.
   def vite_preload_tag(*sources, crossorigin:, **options)
-    asset_paths = sources.map { |source| path_to_asset(source) }
+    url_options = options.extract!(:host, :protocol)
+    asset_paths = sources.map { |source| path_to_asset(source, **url_options) }
     try(:request).try(
       :send_early_hints,
       'Link' => asset_paths.map { |href|