Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with non-interacting players #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pugzy
Copy link

@Pugzy Pugzy commented Nov 10, 2023

Not a clue what I'm doing with these patches to be honest but it works (I think).

Fixes two issues with "observers" i.e. players who are non-interacting using the ad() check.
For EntityLiving players this does a collidesWithEntities check and a parent ad which checks for !this.dead.

Prevents non-interacting players from stopping boat placement

  • Entities with collision turned off will no longer prevent players from placing boats that would collide with them.
  • This implementation also extends to other entities which do not have a hitbox.
    • This means that entities such as items and arrows also no longer block arrows (default in newer versions of MC) .

Prevents non-interacting players from being given armor from a dispenser

  • Players in an "Observers" mode could stand in front of a dispenser and be given the items.
  • Changes a method which uses !alive to the ad() which includes both a collision and alive check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant