-
Notifications
You must be signed in to change notification settings - Fork 13
Comments
Not execatly sure how to do this in the current state of the pipeline. There is no docker inside the PR and master stage, so there is no possibilities of running diesel inside those stages. |
When you build the backend, it always runs the migrations. So the easiest way probably is to run these tests directly after building. Btw. #644 would fail these migration tests (on purpose). |
Ok, that was a misunderstanding from my side, I see what you want now. |
I think the tests are not yet complete. The test should also check if the generated schema stays the same after redoing the migrations. Ideally, they would also test if no data gets removed. (Changes in triggers etc. like done in #684 are out-of-scope as this can be easily seen in code reviews and the potential harm for the productive system is small.) |
@filo14 great work, are all scenarios written in the top post tested now? Please check them. |
@markus2330 we check all of these, if that is what is meant:
|
We should run:
diesel migration redo
anddiesel migration redo -a
within the PR CI jobdiesel migration redo
within the master (dev) CI jobsto test if migrations can successfully be redone.
The text was updated successfully, but these errors were encountered: