Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Grid fixes and improvements. #1183

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

badnames
Copy link
Member

@badnames badnames commented Feb 9, 2024

Basics

  • I added a line to changelog.md
  • The PR is rebased with current master.
  • Details of what you changed are in commit messages.
  • References to issues, e.g. close #X, are in the commit messages and changelog.
  • The buildserver is happy.

Checklist

  • I have installed and I am using pre-commit hooks
  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines

@badnames badnames force-pushed the feature/680-grid-improvements branch from 2e8740e to cca7b0c Compare February 9, 2024 15:00
@badnames badnames requested a review from markus2330 February 9, 2024 15:14
@badnames
Copy link
Member Author

badnames commented Feb 9, 2024

I have added lines at y=0 and x=0 to indicate where the origin is on the map.
@markus2330 can you please take a look at the usecase and tell me if there is still something missing?

image

@badnames badnames marked this pull request as ready for review February 9, 2024 15:18
@yvonnemarkl
Copy link
Contributor

jenkins build please

@badnames
Copy link
Member Author

jenkins build please

Copy link
Contributor

@andreicristian97 andreicristian97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code seems good, did not test it locally.
Noted one small typo in doc.

- The user sees a variable scale coordinate grid with 1 meter, 10 meter and 10 centimeter spacings depending on the current map scale.
- A yard stick displays the current scale of the coordinate grid.
- The origin point is marked on the map.
- The grid can be toggled on and of using a button in the top right toolbar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, in "on and of", should be "off"

@badnames badnames linked an issue Apr 3, 2024 that may be closed by this pull request
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid
3 participants