Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Improve documentation of schema.rs patch workflow. #1232

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

chr-schr
Copy link
Contributor

Improved the documentation of schema.rs patch workflow

Basics

Relevant issue #1193
Separated out of #1191

  • The PR is rebased with current master
  • I added a line to changelog.md
  • Details of what I changed are in the commit messages
  • References to issues, e.g. close #X, are in the commit messages and changelog
  • The buildserver is happy

Checklist

  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

First Time Checklist

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@chr-schr chr-schr added documentation Improvements or additions to documentation please review Review by unspecified person requested labels Mar 29, 2024
@chr-schr chr-schr linked an issue Mar 29, 2024 that may be closed by this pull request
2 tasks
@chr-schr chr-schr requested a review from markus2330 March 29, 2024 13:48
Copy link
Contributor

@hatchla hatchla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@chr-schr chr-schr requested a review from horenso April 6, 2024 12:23
@markus2330 markus2330 merged commit 508fb49 into master Apr 8, 2024
1 check passed
@markus2330 markus2330 deleted the 1193-improving-schema-rs-workflow branch April 8, 2024 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation please review Review by unspecified person requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving schema.rs workflow
3 participants