Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elektrify with highlevel API and code-generation #7

Merged
merged 73 commits into from
Oct 7, 2019
Merged
Changes from 1 commit
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
35f1ab4
elektra: create base for highlevel implementation
kodebach May 9, 2019
65c3cdd
lcdvc: add command line options to spec
kodebach May 9, 2019
13e21c1
lcdvc: elektrify with codegen
kodebach May 10, 2019
0f0f625
lcdproc: elektrify lcdproc client using codegen
kodebach May 10, 2019
8cea575
lcdd: elektrify server core with code-gen
kodebach May 14, 2019
d905f6f
curses: elektrify driver using code-gen
kodebach May 15, 2019
624d778
all: ignore elektragen files
kodebach May 15, 2019
7953017
drivers: elektrify default drivers
kodebach May 16, 2019
63582f2
all: fix gitingores
kodebach May 16, 2019
3b19945
lcdproc: base config
kodebach May 16, 2019
bbb132b
all: update TODOs
kodebach May 16, 2019
9a9d124
lcdproc: screens defined on command-line
kodebach May 16, 2019
30344e7
server: update spec
kodebach May 19, 2019
dbac557
server: remove ignored files
kodebach May 19, 2019
b7d1458
lcdexec: elektrify with codegen
kodebach May 20, 2019
105b9f0
lcdexec: fix bug
kodebach May 22, 2019
eeb6ec2
lcdproc: fix specification
kodebach May 22, 2019
e635115
linux_input. elektrify with codegen
kodebach May 22, 2019
b01933d
xosd: elektrify with codegen
kodebach May 22, 2019
392ac4e
all: update to use enum to_const_string
kodebach May 25, 2019
6b715da
hd44780: elektrify with codegen
kodebach May 25, 2019
e1a7342
lcdproc: fix includes and warnings
kodebach Jun 7, 2019
fe42f62
lcdvc: fix warings
kodebach Jun 7, 2019
c36dbaa
lcdexec: fix memory bug
kodebach Jun 7, 2019
0aff778
drivers: fix unicode problems
kodebach Jun 7, 2019
06f011f
mtxorb: extract keymap reading into function
kodebach Jun 7, 2019
789e258
all: remove shared/configfile and shared/getopt
kodebach Jun 7, 2019
4dff51c
all: remove shared/snprintf
kodebach Jun 7, 2019
31bbb75
drivers: switch from Get2 to FillStruct
kodebach Jun 7, 2019
b224807
server: fix warnings
kodebach Jun 7, 2019
fe29b73
shared: fix warnings
kodebach Jun 7, 2019
7641433
drivers: fix warnings
kodebach Jun 7, 2019
945d7dc
all: remove files that shouldn't exist
kodebach Jun 8, 2019
6bc838c
clients: update readconf.py
kodebach Jun 8, 2019
6a8af21
all: fix/update specifications
kodebach Jun 8, 2019
48ba852
server: move unused spec parts to separate file
kodebach Jun 8, 2019
7973efc
readconf: switch to ini, because of too many plugins
kodebach Jun 8, 2019
3a188c5
all: switch to external spec
kodebach Jul 28, 2019
0604008
doc: add basic documentation about elektra
kodebach Jul 28, 2019
508ee6d
lcdproc: fix spec
kodebach Jul 30, 2019
f052c0d
lcdproc: change how base config is loaded
kodebach Jul 30, 2019
f4b2417
all: update todos
kodebach Jul 30, 2019
4eb070e
hd44780: fix rpi version
kodebach Jul 30, 2019
4f2a706
lcdproc: fix include paths
kodebach Aug 1, 2019
913598f
all: update template from elektra to highlevel
kodebach Aug 26, 2019
2a5b716
all: ignore all elektragen files
kodebach Aug 30, 2019
26a0327
all: update to newest elektra
kodebach Aug 30, 2019
d987801
server: make driver/#0 required
kodebach Aug 30, 2019
c571588
all: add post-install script
kodebach Aug 30, 2019
9f6b6bc
all: mv generated files instead of copying
kodebach Sep 2, 2019
41ddac7
all: remove ignored files
kodebach Sep 2, 2019
e560657
server: make first driver required (works now)
kodebach Sep 2, 2019
4af024c
docs: update elektra readme
kodebach Sep 2, 2019
94b5532
all: add newline to error message
kodebach Sep 2, 2019
dbc2929
all: update todos
kodebach Sep 2, 2019
4d6a52e
doc: update Elektra version requirement
kodebach Sep 7, 2019
ac69c57
lcdexec: use tagPrefix=CONF_
kodebach Sep 7, 2019
6aa793e
lcdvc: use tagPrefix=CONF_
kodebach Sep 7, 2019
e19ce4d
lcdproc: use tagPrefix=CONF_
kodebach Sep 7, 2019
d91d1d5
server: use tagPrefix=CONF_
kodebach Sep 7, 2019
58cd8d1
clients: exit immediately after help message
kodebach Sep 9, 2019
50f2430
lcdexec: add setup script for creating menus
kodebach Sep 10, 2019
aeabb35
ignore generated post-install script
kodebach Sep 10, 2019
4a97d5f
lcdexec: install setup script
kodebach Sep 10, 2019
8da1034
lcdexec: add delete command to setup script
kodebach Sep 12, 2019
822380e
lcdd: use $ORIGIN so uninstalled server can be executed from anywhere
kodebach Sep 15, 2019
1244bbd
server: fix typo
kodebach Sep 19, 2019
8d0ca88
lcdexec: fix help message in setup script
kodebach Sep 22, 2019
773ae76
Merge branch 'master' into elektra_highlevel
kodebach Sep 22, 2019
bfa6140
lcdexec: some fixes for setup script
kodebach Sep 22, 2019
ab49d06
all: include config.h into report.h
kodebach Sep 22, 2019
7233372
lcdexec: fix various problems
kodebach Sep 22, 2019
3e2b9d3
all: use ni plugin instead of ini
kodebach Sep 30, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
server: use tagPrefix=CONF_
kodebach committed Sep 7, 2019
commit d91d1d55e646c7895a3deba1d9ded5f0c03d3708
2 changes: 1 addition & 1 deletion server/Makefile.am
Original file line number Diff line number Diff line change
@@ -27,6 +27,6 @@ spec_DATA = LCDd.spec.eqd

KDB ?= kdb
elektragen.c elektragen.h LCDd.spec.eqd LCDd.mount.sh: specification/LCDd-spec.ini
$(KDB) gen -F ni=specification/LCDd-spec.ini highlevel "spec/sw/lcdproc/lcdd/#0/current" elektragen initFn=loadConfiguration helpFn=printHelpMessage embeddedSpec=defaults; mv elektragen.mount.sh LCDd.mount.sh; mv elektragen.spec.eqd LCDd.spec.eqd
$(KDB) gen -F ni=specification/LCDd-spec.ini highlevel "spec/sw/lcdproc/lcdd/#0/current" elektragen initFn=loadConfiguration helpFn=printHelpMessage embeddedSpec=defaults tagPrefix=CONF_; mv elektragen.mount.sh LCDd.mount.sh; mv elektragen.spec.eqd LCDd.spec.eqd

## EOF
2 changes: 1 addition & 1 deletion server/driver.c
Original file line number Diff line number Diff line change
@@ -141,7 +141,7 @@ driver_load(Elektra * elektra, const char * driverpath, kdb_long_long_t index)
strcpy(&filename[len_driverpath + len_file], MODULE_EXTENSION);

/* extract name for passing to driver */
const char * reference = elektraGetV(elektra, ELEKTRA_TAG_SERVER_DRIVERS, index);
const char * reference = elektraGetV(elektra, CONF_SERVER_DRIVERS, index);
const char * index_start = strrchr(reference, '#') - 1;
const char * name_start = index_start - 1;
while (*name_start != '/') {
2 changes: 1 addition & 1 deletion server/drivers.c
Original file line number Diff line number Diff line change
@@ -65,7 +65,7 @@ drivers_load_driver(Elektra * elektra, kdb_long_long_t index)
}

/* Retrieve data from config file */
const char * driverpath = elektraGet(elektra, ELEKTRA_TAG_SERVER_DRIVERPATH);
const char * driverpath = elektraGet(elektra, CONF_SERVER_DRIVERPATH);

/* Load the module */
driver = driver_load(elektra, driverpath, index);
2 changes: 1 addition & 1 deletion server/drivers/CFontz.c
Original file line number Diff line number Diff line change
@@ -127,7 +127,7 @@ CFontz_init(Driver *drvthis, Elektra * elektra)
/* Read config */

CFontzDriverConfig config;
elektraFillStructV (elektra, &config, ELEKTRA_TAG_CFONTZ, drvthis->index);
elektraFillStructV (elektra, &config, CONF_CFONTZ, drvthis->index);

/* Which device should be used */
report(RPT_INFO, "%s/#"ELEKTRA_LONG_LONG_F": using Device %s", drvthis->name, drvthis->index, config.device);
2 changes: 1 addition & 1 deletion server/drivers/CFontzPacket.c
Original file line number Diff line number Diff line change
@@ -150,7 +150,7 @@ CFontzPacket_init (Driver *drvthis, Elektra * elektra)

/* Read config */
CFontzPacketDriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_CFONTZPACKET, drvthis->index);
elektraFillStructV(elektra, &config, CONF_CFONTZPACKET, drvthis->index);

/* Try to find a matching model from our list of known modules */
debug(RPT_INFO, "%s: Model (in config) is '%d'", __FUNCTION__, config.model);
2 changes: 1 addition & 1 deletion server/drivers/CwLnx.c
Original file line number Diff line number Diff line change
@@ -474,7 +474,7 @@ CwLnx_init(Driver *drvthis, Elektra * elektra)
/* Read config */

CwLnxDriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_CWLNX, drvthis->index);
elektraFillStructV(elektra, &config, CONF_CWLNX, drvthis->index);

/* Which model is it (1602, 12232 or 12832)? */
p->model = config.model;
2 changes: 1 addition & 1 deletion server/drivers/MtxOrb.c
Original file line number Diff line number Diff line change
@@ -261,7 +261,7 @@ MtxOrb_init (Driver *drvthis, Elektra *elektra)

/* READ CONFIG FILE */
MtxOrbDriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_MTXORB, drvthis->index);
elektraFillStructV(elektra, &config, CONF_MTXORB, drvthis->index);

/* Get serial device to use */
report(RPT_INFO, "%s/#"ELEKTRA_LONG_LONG_F": using Device %s", drvthis->name, drvthis->index, config.device);
2 changes: 1 addition & 1 deletion server/drivers/bayrad.c
Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@ bayrad_init(Driver *drvthis, Elektra * elektra)
/* Read config */

BayradDriverConfig config;
elektraFillStructV (elektra, &config, ELEKTRA_TAG_BAYRAD, drvthis->index);
elektraFillStructV (elektra, &config, CONF_BAYRAD, drvthis->index);

/* What device should be used */
report(RPT_INFO, "%s/#"ELEKTRA_LONG_LONG_F": using Device %s", drvthis->name, drvthis->index, config.device);
2 changes: 1 addition & 1 deletion server/drivers/curses_drv.c
Original file line number Diff line number Diff line change
@@ -179,7 +179,7 @@ curses_init (Driver *drvthis, Elektra * elektra)
/* Get settings from config */

CursesDriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_CURSES, drvthis->index);
elektraFillStructV(elektra, &config, CONF_CURSES, drvthis->index);

/* Get color settings */

2 changes: 1 addition & 1 deletion server/drivers/glk.c
Original file line number Diff line number Diff line change
@@ -118,7 +118,7 @@ glk_init(Driver *drvthis, Elektra * elektra)

/* Read config */
GlkDriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_GLK, drvthis->index);
elektraFillStructV(elektra, &config, CONF_GLK, drvthis->index);

/* What device should be used */
report(RPT_INFO, "%s/#"ELEKTRA_LONG_LONG_F": using Device %s", drvthis->name, drvthis->index, config.device);
10 changes: 5 additions & 5 deletions server/drivers/hd44780.c
Original file line number Diff line number Diff line change
@@ -193,10 +193,10 @@ static int get_config_backlight_type(Driver *drvthis, const Hd44780DriverConfig
}

int result = BACKLIGHT_NONE;
kdb_long_long_t size = elektraSizeV(elektra, ELEKTRA_TAG_HD44780_BACKLIGHTMODE, drvthis->index);
kdb_long_long_t size = elektraSizeV(elektra, CONF_HD44780_BACKLIGHTMODE, drvthis->index);
for (kdb_long_long_t i = 0; i < size; ++i)
{
ElektraEnumHd44780Backlightmode elektraMode = elektraGetV(elektra, ELEKTRA_TAG_HD44780_BACKLIGHTMODE, drvthis->index, i);
ElektraEnumHd44780Backlightmode elektraMode = elektraGetV(elektra, CONF_HD44780_BACKLIGHTMODE, drvthis->index, i);
int mode = map_backlight_mode(elektraMode);
if (mode < 0) {
report(RPT_ERR, "%s ("ELEKTRA_LONG_LONG_F"): unknown Backlight mode: %d", drvthis->name, drvthis->index, elektraMode);
@@ -299,7 +299,7 @@ HD44780_init(Driver *drvthis, Elektra * elektra)

/* READ THE CONFIG */
Hd44780DriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_HD44780, drvthis->index);
elektraFillStructV(elektra, &config, CONF_HD44780, drvthis->index);

// TODO (elektra): use hexnumber?
p->port = (unsigned int)strtoul(config.port, NULL, 16); /* works because, spec enforces hex string */
@@ -449,7 +449,7 @@ HD44780_init(Driver *drvthis, Elektra * elektra)

/* Read keymap */
for (x = 0; x < KEYPAD_MAXX; x++) {
const char * key = elektraGetV(elektra, ELEKTRA_TAG_HD44780_KEYDIRECT, drvthis->index, x);
const char * key = elektraGetV(elektra, CONF_HD44780_KEYDIRECT, drvthis->index, x);

/* Was a key specified in the config file ? */
if (strlen(key) == 0) {
@@ -461,7 +461,7 @@ HD44780_init(Driver *drvthis, Elektra * elektra)
p->keyMapDirect[x] = strdup(key);

for (y = 0; y < KEYPAD_MAXY; y++) {
key = elektraGetV(elektra, ELEKTRA_TAG_HD44780_KEYMATRIX, drvthis->index, x, y);
key = elektraGetV(elektra, CONF_HD44780_KEYMATRIX, drvthis->index, x, y);

/* Was a key specified in the config file ? */
if (strlen(key) == 0) {
2 changes: 1 addition & 1 deletion server/drivers/lb216.c
Original file line number Diff line number Diff line change
@@ -95,7 +95,7 @@ LB216_init(Driver *drvthis, Elektra * elektra)

/* Read config */
Lb216DriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_LB216, drvthis->index);
elektraFillStructV(elektra, &config, CONF_LB216, drvthis->index);

/* What device should be used */
report(RPT_INFO, "%s/#"ELEKTRA_LONG_LONG_F": using Device %s", drvthis->name, drvthis->index, config.device);
2 changes: 1 addition & 1 deletion server/drivers/lcdm001.c
Original file line number Diff line number Diff line change
@@ -161,7 +161,7 @@ lcdm001_init (Driver *drvthis, Elektra * elektra)

/* READ CONFIG FILE: */
Lcdm001DriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_LCDM001, drvthis->index);
elektraFillStructV(elektra, &config, CONF_LCDM001, drvthis->index);

/* which serial device should be used */
report(RPT_INFO, "%s/#"ELEKTRA_LONG_LONG_F": using Device %s", drvthis->name, drvthis->index, config.device);
8 changes: 4 additions & 4 deletions server/drivers/linux_input.c
Original file line number Diff line number Diff line change
@@ -75,7 +75,7 @@ linuxInput_init (Driver *drvthis, Elektra * elektra)
/* not using struct, since it is inconvenient for keymap */

/* What device should be used */
const char * device = elektraGetV(elektra, ELEKTRA_TAG_LINUX_INPUT_DEVICE, drvthis->index);
const char * device = elektraGetV(elektra, CONF_LINUX_INPUT_DEVICE, drvthis->index);
report(RPT_INFO, "%s: using Device %s", drvthis->name, device);


@@ -85,12 +85,12 @@ linuxInput_init (Driver *drvthis, Elektra * elektra)
return -1;
}

kdb_long_long_t size = elektraSizeV(elektra, ELEKTRA_TAG_LINUX_INPUT_KEYS, drvthis->index);
kdb_long_long_t size = elektraSizeV(elektra, CONF_LINUX_INPUT_KEYS, drvthis->index);

for (kdb_long_long_t i = 0; i < size; ++i) {
struct keycode * key = malloc(sizeof(struct keycode));
key->code = elektraGetV(elektra, ELEKTRA_TAG_LINUX_INPUT_KEYS_CODE, drvthis->index, i);
key->button = strdup(elektraGetV(elektra, ELEKTRA_TAG_LINUX_INPUT_KEYS_BUTTON, drvthis->index, i));
key->code = elektraGetV(elektra, CONF_LINUX_INPUT_KEYS_CODE, drvthis->index, i);
key->button = strdup(elektraGetV(elektra, CONF_LINUX_INPUT_KEYS_BUTTON, drvthis->index, i));
LL_AddNode(p->buttonmap, key);
}

2 changes: 1 addition & 1 deletion server/drivers/pylcd.c
Original file line number Diff line number Diff line change
@@ -327,7 +327,7 @@ pyramid_init(Driver *drvthis, Elektra * elektra)
*/

PyramidDriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_PYRAMID, drvthis->index);
elektraFillStructV(elektra, &config, CONF_PYRAMID, drvthis->index);

/* Which serial device should be used? */
report(RPT_INFO, "%s/#"ELEKTRA_LONG_LONG_F": using Device %s", drvthis->name, drvthis->index, config.device);
2 changes: 1 addition & 1 deletion server/drivers/text.c
Original file line number Diff line number Diff line change
@@ -71,7 +71,7 @@ text_init (Driver *drvthis, Elektra * elektra)
/* initialize private data */

TextDriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_TEXT, drvthis->index);
elektraFillStructV(elektra, &config, CONF_TEXT, drvthis->index);

// Set display sizes
if ((drvthis->request_display_width() > 0)
2 changes: 1 addition & 1 deletion server/drivers/xosdlib_drv.c
Original file line number Diff line number Diff line change
@@ -82,7 +82,7 @@ xosdlib_drv_init (Driver *drvthis, Elektra * elektra)

/* Read config */
XosdDriverConfig config;
elektraFillStructV(elektra, &config, ELEKTRA_TAG_XOSD, drvthis->index);
elektraFillStructV(elektra, &config, CONF_XOSD, drvthis->index);

/* Which size */
if ((drvthis->request_display_width() > 0)
10 changes: 5 additions & 5 deletions server/input.c
Original file line number Diff line number Diff line change
@@ -51,11 +51,11 @@ int input_init(Elektra * elektra)
keylist = LL_new();

/* Get rotate/scroll keys from config file */
toggle_rotate_key = strdup(elektraGet(elektra, ELEKTRA_TAG_SERVER_TOGGLEROTATEKEY));
prev_screen_key = strdup(elektraGet(elektra, ELEKTRA_TAG_SERVER_PREVSCREENKEY));
next_screen_key = strdup(elektraGet(elektra, ELEKTRA_TAG_SERVER_NEXTSCREENKEY));
scroll_up_key = strdup(elektraGet(elektra, ELEKTRA_TAG_SERVER_SCROLLUPKEY));
scroll_down_key = strdup(elektraGet(elektra, ELEKTRA_TAG_SERVER_SCROLLDOWNKEY));
toggle_rotate_key = strdup(elektraGet(elektra, CONF_SERVER_TOGGLEROTATEKEY));
prev_screen_key = strdup(elektraGet(elektra, CONF_SERVER_PREVSCREENKEY));
next_screen_key = strdup(elektraGet(elektra, CONF_SERVER_NEXTSCREENKEY));
scroll_up_key = strdup(elektraGet(elektra, CONF_SERVER_SCROLLUPKEY));
scroll_down_key = strdup(elektraGet(elektra, CONF_SERVER_SCROLLDOWNKEY));

return 0;
}
28 changes: 14 additions & 14 deletions server/main.c
Original file line number Diff line number Diff line change
@@ -306,27 +306,27 @@ process_config()

elektraFatalErrorHandler(elektra, on_fatal_error);

bind_port = elektraGet(elektra, ELEKTRA_TAG_SERVER_PORT);
strncpy(bind_addr, elektraGet(elektra, ELEKTRA_TAG_SERVER_BIND), sizeof(bind_addr));
strncpy(user, elektraGet(elektra, ELEKTRA_TAG_SERVER_USER), sizeof(user));
bind_port = elektraGet(elektra, CONF_SERVER_PORT);
strncpy(bind_addr, elektraGet(elektra, CONF_SERVER_BIND), sizeof(bind_addr));
strncpy(user, elektraGet(elektra, CONF_SERVER_USER), sizeof(user));

frame_interval = elektraGet(elektra, ELEKTRA_TAG_SERVER_FRAMEINTERVAL);
default_duration = elektraGet(elektra, ELEKTRA_TAG_SERVER_WAITTIME) * 1e6 / frame_interval;
frame_interval = elektraGet(elektra, CONF_SERVER_FRAMEINTERVAL);
default_duration = elektraGet(elektra, CONF_SERVER_WAITTIME) * 1e6 / frame_interval;
if (default_duration * frame_interval < 2e6) {
report(RPT_WARNING, "Waittime should be at least 2 (seconds). Set to 2 seconds.");
default_duration = 2e6 / frame_interval;
}

foreground_mode = elektraGet(elektra, ELEKTRA_TAG_SERVER_FOREGROUND);
rotate_server_screen = elektraGet(elektra, ELEKTRA_TAG_SERVER_SERVERSCREEN);
backlight = elektraGet(elektra, ELEKTRA_TAG_SERVER_BACKLIGHT);
heartbeat = elektraGet(elektra, ELEKTRA_TAG_SERVER_HEARTBEAT);
autorotate = elektraGet(elektra, ELEKTRA_TAG_SERVER_AUTOROTATE);
foreground_mode = elektraGet(elektra, CONF_SERVER_FOREGROUND);
rotate_server_screen = elektraGet(elektra, CONF_SERVER_SERVERSCREEN);
backlight = elektraGet(elektra, CONF_SERVER_BACKLIGHT);
heartbeat = elektraGet(elektra, CONF_SERVER_HEARTBEAT);
autorotate = elektraGet(elektra, CONF_SERVER_AUTOROTATE);

titlespeed = elektraGet(elektra, ELEKTRA_TAG_SERVER_TITLESPEED);
report_dest = (elektraGet(elektra, ELEKTRA_TAG_SERVER_REPORTTOSYSLOG)) ? RPT_DEST_SYSLOG : RPT_DEST_STDERR;
titlespeed = elektraGet(elektra, CONF_SERVER_TITLESPEED);
report_dest = (elektraGet(elektra, CONF_SERVER_REPORTTOSYSLOG)) ? RPT_DEST_SYSLOG : RPT_DEST_STDERR;

report_level = elektraGet(elektra, ELEKTRA_TAG_SERVER_REPORTLEVEL);
report_level = elektraGet(elektra, CONF_SERVER_REPORTLEVEL);

return 0;
}
@@ -458,7 +458,7 @@ init_drivers(void)
debug(RPT_DEBUG, "%s()", __FUNCTION__);

/* Read drivers */
num_drivers = elektraSize(elektra, ELEKTRA_TAG_SERVER_DRIVERS);
num_drivers = elektraSize(elektra, CONF_SERVER_DRIVERS);
for (kdb_long_long_t i = 0; i < num_drivers; ++i) {
if(i > MAX_DRIVERS)
{
14 changes: 7 additions & 7 deletions server/menuscreens.c
Original file line number Diff line number Diff line change
@@ -85,7 +85,7 @@ menuscreens_init(Elektra * elektra)

debug(RPT_DEBUG, "%s()", __FUNCTION__);

menu_permissive_goto = elektraGet(elektra, ELEKTRA_TAG_MENU_PERMISSIVEGOTO);
menu_permissive_goto = elektraGet(elektra, CONF_MENU_PERMISSIVEGOTO);

/*
* Get keys from config file: MenuKey, EnterKey, UpKey, DownKey,
@@ -94,36 +94,36 @@ menuscreens_init(Elektra * elektra)
*/
keymask = 0;
menu_key = enter_key = NULL;
tmp = elektraGet(elektra, ELEKTRA_TAG_MENU_MENUKEY);
tmp = elektraGet(elektra, CONF_MENU_MENUKEY);
if (strlen(tmp) > 0) {
menu_key = strdup(tmp);
keymask |= MENUTOKEN_MENU;
}
tmp = elektraGet(elektra, ELEKTRA_TAG_MENU_ENTERKEY);
tmp = elektraGet(elektra, CONF_MENU_ENTERKEY);
if (strlen(tmp) > 0) {
enter_key = strdup(tmp);
keymask |= MENUTOKEN_ENTER;
}

up_key = down_key = NULL;
tmp = elektraGet(elektra, ELEKTRA_TAG_MENU_UPKEY);
tmp = elektraGet(elektra, CONF_MENU_UPKEY);
if (strlen(tmp) > 0) {
up_key = strdup(tmp);
keymask |= MENUTOKEN_UP;
}
tmp = elektraGet(elektra, ELEKTRA_TAG_MENU_DOWNKEY);
tmp = elektraGet(elektra, CONF_MENU_DOWNKEY);
if (strlen(tmp) > 0) {
down_key = strdup(tmp);
keymask |= MENUTOKEN_DOWN;
}

left_key = right_key = NULL;
tmp = elektraGet(elektra, ELEKTRA_TAG_MENU_LEFTKEY);
tmp = elektraGet(elektra, CONF_MENU_LEFTKEY);
if (strlen(tmp) > 0) {
left_key = strdup(tmp);
keymask |= MENUTOKEN_LEFT;
}
tmp = elektraGet(elektra, ELEKTRA_TAG_MENU_RIGHTKEY);
tmp = elektraGet(elektra, CONF_MENU_RIGHTKEY);
if (strlen(tmp) > 0) {
right_key = strdup(tmp);
keymask |= MENUTOKEN_RIGHT;
8 changes: 4 additions & 4 deletions server/serverscreens.c
Original file line number Diff line number Diff line change
@@ -64,7 +64,7 @@ server_screen_init(Elektra * elektra)
Widget *w;
int i;

kdb_long_long_t helloArraySize = elektraSize(elektra, ELEKTRA_TAG_SERVER_GOODBYE);
kdb_long_long_t helloArraySize = elektraSize(elektra, CONF_SERVER_GOODBYE);
has_hello_msg = helloArraySize > 0;

debug(RPT_DEBUG, "%s()", __FUNCTION__);
@@ -100,7 +100,7 @@ server_screen_init(Elektra * elektra)
/* set the widgets depending on the Hello option in LCDd.conf */
if (has_hello_msg) { /* show whole Hello message */
for (kdb_long_long_t i = 0; i < display_props->height && i < helloArraySize; i++) {
const char *line = elektraGetV(elektra, ELEKTRA_TAG_SERVER_HELLO, i);
const char *line = elektraGetV(elektra, CONF_SERVER_HELLO, i);
char id[30];

sprintf(id, "line"ELEKTRA_LONG_LONG_F, i+1);
@@ -218,11 +218,11 @@ goodbye_screen(Elektra * elektra)

drivers_clear();

kdb_long_long_t arraySize = elektraSize(elektra, ELEKTRA_TAG_SERVER_GOODBYE);
kdb_long_long_t arraySize = elektraSize(elektra, CONF_SERVER_GOODBYE);
if (arraySize > 0) { /* custom GoodBye */
/* loop over all display lines to read config & display message */
for (kdb_long_long_t i = 0; i < display_props->height && i < arraySize; i++) {
const char *line = elektraGetV(elektra, ELEKTRA_TAG_SERVER_GOODBYE, i);
const char *line = elektraGetV(elektra, CONF_SERVER_GOODBYE, i);

drivers_string(1, 1+i, line);
}