Skip to content
This repository was archived by the owner on Feb 16, 2025. It is now read-only.

[FLOSS H3] toml: fix silent failure on meta-key insertion #4720

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

Bujuhu
Copy link
Contributor

@Bujuhu Bujuhu commented Nov 28, 2022

Fixes #4579

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and no further pushes are planned by you.

@Bujuhu Bujuhu force-pushed the toml/metakeyvalidation branch 2 times, most recently from 8bdd260 to 06aeaaa Compare November 28, 2022 10:07
@Bujuhu Bujuhu force-pushed the toml/metakeyvalidation branch from 2f40abc to 6da5aab Compare November 29, 2022 03:27
@Bujuhu Bujuhu force-pushed the toml/metakeyvalidation branch from 6da5aab to a2f699f Compare November 29, 2022 03:35
@stefnotch stefnotch added the H3 label Nov 30, 2022
@Dynamichost96
Copy link
Contributor

Documentation is introductory, concise, good to read and describes everything what the PR does

All good!

Examples are well chosen and understandable
N/A

Code is conforming to our Coding Guidelines
Code is conforming to the Guidelines

APIs are conforming to our Design Guidelines
N/A

Code is consistent to our Design Decisions
Code is consistent to the Guidelines

@markus2330 markus2330 merged commit 046f26d into ElektraInitiative:master Dec 5, 2022
@markus2330
Copy link
Contributor

Great job! ❤️

@Bujuhu Bujuhu deleted the toml/metakeyvalidation branch December 12, 2022 21:33
@mpranj mpranj added this to the 0.9.12 milestone Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLOSS] Toml plugin fails silently on meta-set
7 participants