25.05 NEXT_VERSION update, and deprecations. #8118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some confusion or missing context on the commit 20aff85 We could add the in the commit body a little bit of context? in this way, people that will find this (like me now) can understand what it is changing and why? |
rustyrussell
force-pushed
the
guilt/deprecated-25.05
branch
from
829412d to
e004102
Compare
If you look in the CHANGELOG you can see back when they were deprecated, it was described in detail. And unless you manually re-enabled it in your config with i-promise-to-fix-broken-api-user= you have been running without it since v24.11. So I'm pretty sure nobody will notice. I chose not to re-type all those old messages? |
rustyrussell
force-pushed
the
guilt/deprecated-25.05
branch
from
e004102 to
92ecc56
Compare
It makes sense, but our changelogs are 10 meters long and it is easy to miss stuff out I am sure that people with tools like screen readers are not able to read it (like I am not able to do 😄), but I find the commit 2c2463a so all good! Git blame works well! |
rustyrussell
force-pushed
the
guilt/deprecated-25.05
branch
2 times, most recently
from
c57e9a6 to
fc2f338
Compare
_in_ versions complain if used, _out_ don't (since we don't know if they are going to use it). This was the wrong choice, and thus causes a BROKEN log message when we update CLN_NEXT_VERSION. Signed-off-by: Rusty Russell <[email protected]>
…do_stress any more. In d18f564 "pytest: stop using deprecated commando_rune commands." we stopped using deprecated commands in these tests, but we didn't remove the 'allow-deprecated-apis' flag. Signed-off-by: Rusty Russell <[email protected]>
…utput. Somehow we missed this when we added libplugin support. Signed-off-by: Rusty Russell <[email protected]>
When we update the CLN_NEXT_VERSION, these will only be available with --i-promise-to-fix-broken-api-user. Signed-off-by: Rusty Russell <[email protected]>
We now have to explicitly enable various deprecated commando commands, and now when deprecations are disabled, we honour missing MPP option in bolt12 invoices. Signed-off-by: Rusty Russell <[email protected]>
We haven't printed this since v24.08. Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: listconfigs raw listing (deprecated v23.08, disabled by default in v24.11).
Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: connection/disconnection/block_added notification raw fields (deprecated v23.08, disabled by default in v24.11).
Changelog-Removed: accept-htlc-tlv-types (deprecated v23.08, disabled by default in v24.11). Signed-off-by: Rusty Russell <[email protected]>
… sockets. Changelog-Removed: --bind-addr and --addr on onion addresses and local sockets (deprecated v23.08, disabled by default in v24.11). Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: Config: `announce-addr-dns` (deprecated v23.08, disabled in v24.11).
Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: allowing 0/1 instead of false/true for plugin options (deprecated v23.08, disabled by default in v24.11).
…t values. Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: default settings for flag options in plugins which aren't "false".
Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: plugins which didn't accept string JSON RPC fields (deprecated v23.08, disabled by default in v24.11).
rustyrussell
force-pushed
the
guilt/deprecated-25.05
branch
from
fc2f338 to
00d4272
Compare
Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: RPC `listchannels` no longer includes private local channels (deprecated v23.08, disabled by default in v24.11).
rustyrussell
force-pushed
the
guilt/deprecated-25.05
branch
from
00d4272 to
538c4a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the removals of deactivated features for the coming release.