Skip to content

feat: Numeric bench#2835

Open
Gresham429 wants to merge 6 commits intoEleutherAI:mainfrom
Gresham429:numeric_bench
Open

feat: Numeric bench#2835
Gresham429 wants to merge 6 commits intoEleutherAI:mainfrom
Gresham429:numeric_bench

Conversation

@Gresham429
Copy link
Copy Markdown

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 24, 2025

CLA assistant check
All committers have signed the CLA.

@baberabb
Copy link
Copy Markdown
Contributor

Hi! Thanks for the PR. Looks good to merge once you run the pre-commit:

pip install pre-commit
pre-commit install
pre-commit run --all-files

@Gresham429
Copy link
Copy Markdown
Author

Hi! Thanks for the PR. Looks good to merge once you run the pre-commit:

pip install pre-commit
pre-commit install
pre-commit run --all-files

thanks for helping, I've been a bit busy lately, but I'll fix these bugs in a few days.

@baberabb
Copy link
Copy Markdown
Contributor

baberabb commented Mar 25, 2025

thanks for helping, I've been a bit busy lately, but I'll fix these bugs in a few days.

no problem! Also noticed you have a system prompt, but using it in doc_to_text. Wasn't sure if you're aware, you can use the description field for it. It will format to the system prompt in case the chat template is used, otherwise prepended to the doc_to_text (before the few-shots, if used). see parameters

@baberabb baberabb self-assigned this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants