Skip to content

Conversation

@grzegorz-aniol
Copy link

@grzegorz-aniol grzegorz-aniol commented Dec 25, 2025

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2025

CLA assistant check
All committers have signed the CLA.

@djstrong
Copy link
Contributor

I have run it but see some warnings:

2025-12-27:12:23:33 WARNING  [api.task:728] [Task: wmt24pp-en-pl_PL] metric bleu is defined, but aggregation is not. using default aggregation=bleu
2025-12-27:12:23:33 WARNING  [api.task:740] [Task: wmt24pp-en-pl_PL] metric bleu is defined, but higher_is_better is not. using default higher_is_better=True
2025-12-27:12:23:33 WARNING  [api.task:728] [Task: wmt24pp-en-pl_PL] metric ter is defined, but aggregation is not. using default aggregation=ter
2025-12-27:12:23:33 WARNING  [api.task:740] [Task: wmt24pp-en-pl_PL] metric ter is defined, but higher_is_better is not. using default higher_is_better=True
2025-12-27:12:23:33 WARNING  [api.task:728] [Task: wmt24pp-en-pl_PL] metric chrf is defined, but aggregation is not. using default aggregation=chrf
2025-12-27:12:23:33 WARNING  [api.task:740] [Task: wmt24pp-en-pl_PL] metric chrf is defined, but higher_is_better is not. using default higher_is_better=True

@grzegorz-aniol
Copy link
Author

I have run it but see some warnings:

2025-12-27:12:23:33 WARNING  [api.task:728] [Task: wmt24pp-en-pl_PL] metric bleu is defined, but aggregation is not. using default aggregation=bleu
2025-12-27:12:23:33 WARNING  [api.task:740] [Task: wmt24pp-en-pl_PL] metric bleu is defined, but higher_is_better is not. using default higher_is_better=True
2025-12-27:12:23:33 WARNING  [api.task:728] [Task: wmt24pp-en-pl_PL] metric ter is defined, but aggregation is not. using default aggregation=ter
2025-12-27:12:23:33 WARNING  [api.task:740] [Task: wmt24pp-en-pl_PL] metric ter is defined, but higher_is_better is not. using default higher_is_better=True
2025-12-27:12:23:33 WARNING  [api.task:728] [Task: wmt24pp-en-pl_PL] metric chrf is defined, but aggregation is not. using default aggregation=chrf
2025-12-27:12:23:33 WARNING  [api.task:740] [Task: wmt24pp-en-pl_PL] metric chrf is defined, but higher_is_better is not. using default higher_is_better=True

@djstrong I think it's not an issue but I fixed this adding explicit aggregation metric in config file. Thanks to this, TER is correctly reported in output table as ↓ (lower is better)

@grzegorz-aniol
Copy link
Author

@baberabb May I draw your attention on this PR? I added new set of tools for google's wmt24++ translation datasets. Do you see something missing, can it be merged? Thank you

@djstrong
Copy link
Contributor

djstrong commented Jan 7, 2026

Maybe let's make some tests without chat templates, so it works well with base models too?

@grzegorz-aniol
Copy link
Author

Maybe let's make some tests without chat templates, so it works well with base models too?

Ok, I will have to adjust a prompt a bit, to make test working well even without chat template.

@baberabb I will come back to you after verification by some models. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants