79 assert nodes 1 #102
Open
79 assert nodes 1 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
haakon98
commented
Nov 5, 2024
haakon98
commented
- Create a file node_checker.py for validation logic of assert nodes
- Implement logic in test_runner/views.py
* Add API for running test flows
* crud actions for category * refactor mapping from backend model to frontend type * Enhance device category management: add ID to DeviceCategory type, update input handling in forms, and implement Django filters for device queries. * move delete button * Remove unnecessary console logs from device category components and views * add patch device category * add fetching the number of devices associated with a category * style connection type and communication protocol tags on device category page * format code * style fix and format backend code * format backend code * style: align contents of device category card * very tiny style fix * revert file name change * refactor fetch devices based on category id * sort imports * remove comments and add communication protocols to create request * format code
* remove unnecessary status icon * lint
Open
adelefelicia
requested changes
Nov 5, 2024
| result = "Assert OK" | ||
| else: | ||
| result = "Assert failed" | ||
| except Exception as e: |
There was a problem hiding this comment.
Also I think you can omit this try/catch block since the whole function is wrapped in one. We'd like those errors to be sent to the user in case they write invalid python code instead of just catching them and continuing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.