Add publication 1 0 0 #11
Conversation
| properties: | ||
| properties: | ||
| project_id: | ||
| description: Primary key or unique identified for a project |
There was a problem hiding this comment.
@esheetah typo - identifier*
There was a problem hiding this comment.
Correcting this
| description: Link to the ontology file | ||
| url: https://bioportal.bioontology.org/ontologies/ORTH?p=classes&conceptid=http%3A%2F%2Fpurl.org%2Fnet%2Forth%23Organism | ||
| cell_line: | ||
| description: Identifier of the cell lines from which the samples were derived for this experiment |
There was a problem hiding this comment.
@esheetah The description here should simply be the answer to "What is a cell-line"? Description is not a metadata field for the physical data model. It is simply to add more information about the attributes as a part of the conceptual model definition.
There was a problem hiding this comment.
Example section will cover what kind of values can be stored along with the above definition which fits better in the example section.
| type: float | ||
| format: numeric | ||
| example: 70 | ||
| upper_value: 10000.0 |
There was a problem hiding this comment.
@esheetah Use upper limit and lower limit
| @@ -0,0 +1,437 @@ | |||
| Protocol: | |||
There was a problem hiding this comment.
@esheetah A question here. Is this definition specific to a data type? I'd like to ask this because the definition needs to be generic to apply to all data types. If not, we must create a base/core definition followed by data type-specific modules.
| authors: | ||
| description: List of authors for the associated publication | ||
| type: string | ||
| example: "Puyalto A, Rodríguez-Remírez M, López I, Macaya I" |
There was a problem hiding this comment.
@esheetah Publications follow APA style formatting in most cases. This example is APA. Let's add that in the description somewhere?
Also, the initials of the first name will end with a . e.g. Puyalto, A.
There was a problem hiding this comment.
Adding it in the description
| type: string | ||
| description: Link to the ontology file | ||
| url: https://bioportal.bioontology.org/ontologies/OBI?p=classes&conceptid=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FOBI_0001617 | ||
| total_number_of_cells: |
There was a problem hiding this comment.
@esheetah Looks like a data-type specific field. Need to segment these better
| @@ -0,0 +1,88 @@ | |||
| Publication: | |||
There was a problem hiding this comment.
@esheetah Use of double quotes in the example section is inconsistent. Let's either use it or not use it at all. Please review this in other entities wherever applicable
There was a problem hiding this comment.
The examples with string values are given in double quotes, the integer/float examples are not. Should we be giving the numerical values in double quotes as well? @pverma12394
Added Publication file