[FIX] fixed the crashing of app when folder or file contains non-English characters #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1381 +/- ##
===========================================
- Coverage 45.45% 44.59% -0.86%
===========================================
Files 58 42 -16
Lines 9889 6516 -3373
===========================================
- Hits 4495 2906 -1589
+ Misses 5394 3610 -1784
|
ghost
requested review from
sakshikukreja14
approved these changes
Mar 7, 2021
saif-el
approved these changes
Mar 15, 2021
|
@MdAzmatAli Thanks for fixing. Didn't realize it would be this simple. Unicode magic. Can you rebase this branch on the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue can be found at #1375