Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Productionize nf-polly plugin #1

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

saif-el
Copy link
Collaborator

@saif-el saif-el commented Apr 12, 2024

Context

This is a fork of the nf-hello example plugin repository maintained by Nextflow community. We have made the following changes:

  • Renamed the classes and configuration in favor of Polly.
  • Added a utility reportMetric that can be used by all users running pipelines on Polly to send user-defined metrics to our system.
  • Add a nextflow config parameter to control Kinesis stream name, which we will override on infra side itself. User will not set this value.
  • The nf-polly plugin will also be automatically enabled for all pipelines on the infra side (separate PR for this in samvaad).
  • The tests are failing because the nextflow devs have created a harness that works for only public repositories. We need to come back to this and enable it for our own private use-case.

@saif-el saif-el force-pushed the PRD-138/productionize_nf_polly branch from d462009 to 2f4ca46 Compare April 15, 2024 05:12
@saif-el saif-el merged commit cabae54 into main Apr 15, 2024
0 of 2 checks passed
@saif-el saif-el deleted the PRD-138/productionize_nf_polly branch April 15, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants