Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multistate implementation #21

Merged
merged 63 commits into from
Jan 26, 2024
Merged

Multistate implementation #21

merged 63 commits into from
Jan 26, 2024

Conversation

Foereaper
Copy link
Member

Requires the following PR and changing to Master submodule before merging
ElunaLuaEngine/Eluna#455

Multistate implementation to allow the use of multiple map update thread. Each map will have its own isolated Lua state, with a world state for thread-unsafe function calls.

Adds the following additional features:

  • Automatic bytecode precompilation and caching
  • Granular per-state script loading
  • Asynchronous SQL queries with function callbacks
  • Runtime persistent worldobject and map caching
  • Method state-specific tagging
  • Assorted methods for Map
  • Compatibility mode (enabled by default), allowing the engine to run like the old Eluna implementation

This will require some changes on both Mangos and Cmangos forks. I suggest staying on an older Eluna commit until thoroughly tested and implemented.

Foereaper and others added 30 commits August 21, 2022 19:08
@Foereaper
Switch to multistate Eluna branch
4931e7c
@Foereaper
Replace base Lua lib with luajit compatible library
a10463e
@Foereaper
Default to luajit
ee8b845
@Foereaper
Update submodule
f3284cf
@Foereaper
Default to dynamic lua library
a7c2ca0
@Terrorblade
Work in progress basic implementation of per map eluna states.
04acac4
@Terrorblade
Fix compile error from WorldObject::GetEluna() and Main attempting to…
5456533 
… unitalize eluna.
@Terrorblade
Fix missing change to only allow the parent map to update eluna state.
3e393aa
@Terrorblade
Update submodule.
553495a
@Foereaper
Add world state for thread-unsafe functions
bc982c6
@Rochet2
Separate Eluna updating logic from update hook
6e2533c
@Foereaper
Add new Eluna config option
e4a182f
@Terrorblade
Add config to preload parent maps of eluna maps.
a60516c
@Terrorblade
Update Eluna Submodule.
9d4645a
@Terrorblade
Update Eluna Submodule.
5f2853d
@Rochet2
Eluna update version
bbde95e
@Rochet2
Re-enable command hook for console
581bb25
@Rochet2
Eluna update version
1b47d7c
@Rochet2
Fix crash on shutdown
40953f2 
map is set for the bg template only once player enters the instance.
map can thus be nullptr if no one has entered yet.
@Rochet2
Fix lua scripts install path
a59fa35
@Foereaper
merge
58184ad
@Foereaper
Bring multistate up to date
c318038
@Foereaper
Fix build issues after latest merge
2550624
@Foereaper
Spawn a state per child map, not parent map
a6241f0
@Foereaper
Use already existing parent map function
cd9d958
@Foereaper
Update Eluna submodule
cfb1974
@Foereaper
Update Eluna submodule
5e10c40
@Foereaper
Update Eluna submodule
9e91e9f
@Foereaper
Update Eluna submodule
7436d7f
@Foereaper
Update Eluna submodule
b956faa
Foereaper and others added 24 commits January 14, 2024 23:07
@Foereaper
Move data storage to WorldObject and add to Map
cfa7a98
@Foereaper
Add compatibility mode (single threaded)
b96533a 
This should work like stock Eluna
@Foereaper
Fix timed events working across maps in compatibility mode
0ed6006
@Rochet2
Eluna update version
925d0b1
@Foereaper
Update Eluna submodule
745a02a
@Foereaper
Update Eluna submodule
fd985c4
@Foereaper
Update Eluna submodule
60e29e3
@Foereaper
Update Eluna submodule
e9e9a0f
@Foereaper
Merge branch 'master' of https://github.com/elunaluaengine/elunatrini…
248f2da 
…tywotlk into multistate
@Foereaper
Update Eluna submodule
383b791
@Foereaper
Update Eluna submodule
9558213
@Foereaper
Update Eluna submodule
070fca9
@Foereaper
Update Eluna submodule
9153b1c
@Foereaper
Update Eluna submodule
b8ac063
@Foereaper
Save instance ID in the Eluna state
20dac05
@Foereaper
Update Eluna submodule
d0a722e
@Foereaper
Fix crash on parent map unload
6970008 
Apparently parent maps are stored together with the instance maps in i_map
@Foereaper
Update Eluna submodule
5f07d85
@Foereaper
Update Eluna submodule
b85ef21
@Terrorblade
Save map to lua state instead of map id/instance id.
11cafb7
@Terrorblade
Submodule src/LuaEngine updated
9c68e9e 
Submodule src/LuaEngine:
    > 81d76ba - Fix documentation for GetStateMap.
    > d07e0b2 - Save map instead of Map id/instance id combo.
@Foereaper
Update Eluna submodule
a0e4aba
@Foereaper
Merge branch 'master' of https://github.com/elunaluaengine/elunatrini…
368b18c 
…tywotlk into multistate
@Foereaper
Update Eluna Submodule
a8142b8
@Foereaper Foereaper marked this pull request as ready for review January 26, 2024 23:12
@Foereaper Foereaper merged commit fb48e0c into master Jan 26, 2024
2 checks passed
@Foereaper Foereaper deleted the multistate branch February 16, 2024 16:48
@iThorgrim iThorgrim mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Branch-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Foereaper @Terrorblade @Rochet2