Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for {NL} in kick-message #36

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add support for {NL} in kick-message #36

merged 1 commit into from
Jun 25, 2024

Conversation

ANameSpace
Copy link
Contributor

Fix for #29
Added {NL} support for kick-message.

@UserNugget UserNugget linked an issue Jun 25, 2024 that may be closed by this pull request
Kick message cannot line break #29
Closed
@UserNugget
Copy link
Member

UserNugget commented Jun 25, 2024 •
edited
Loading

Hello! Thanks for the PR, but there are some questions:

  1. Does a header change should be in this PR?
  2. Can you please rename PR to something like "Add support for {NL} in kick-message" to make it easier to track/structurize changes in the future/dev-builds?

@ANameSpace ANameSpace changed the title Fix for #29 Add support for {NL} in kick-message Jun 25, 2024
@ANameSpace
Copy link
Contributor Author

  1. Sorry, I sent this commit to the wrong branch. I'll delete it now.
  2. Done.

@UserNugget UserNugget merged commit 8ad8543 into Elytrium:master Jun 25, 2024
2 checks passed
@UserNugget
Copy link
Member

Thanks!

@mdxd44
Copy link
Member

mdxd44 commented Jun 27, 2024

the worst solution possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kick message cannot line break
3 participants
@ANameSpace @UserNugget @mdxd44