Draft: erpcgen: Add namespace and remove typedefs in C++ common header #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippHaefele
force-pushed
the
feature/cpp_common_header_rework
branch
5 times, most recently
from
fe132ff
to
cb97458
Compare
- Forward declrations are needed somehow for same name typedefs - Using constexpr instead of extern const so we can namespace them easily
PhilippHaefele
force-pushed
the
feature/cpp_common_header_rework
branch
from
cb97458
to
61c6ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Choose Correct
Describe the pull request
This PR maybe fixes #418
It adds the namespace and change const to consteexpr in the generated
...._common.hppfileTo Reproduce
See #418
Expected behavior
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context