Skip to content

Update comment regarding notification #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itaybre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update comment regarding notification #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Example/DemoApp/UpdateUtil.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ struct UpdateUtil {
}
DispatchQueue.main.async {
UIApplication.shared.open(url) { _ in
// Post notification event before closing the app
// Post notification event before closing the app, some SDKs may consider exit(0) as an unexpected
// termination otherwise. This is the case for Sentry.
NotificationCenter.default.post(name: UIApplication.willTerminateNotification, object: nil)

// Close the app after a slight delay so it has time to execute code for the notification
Expand Down
3 changes: 2 additions & 1 deletion Sources/ETDistribution.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ public final class ETDistribution: NSObject {
return
}
UIApplication.shared.open(url) { _ in
// Post notification event before closing the app
// Post notification event before closing the app, some SDKs may consider exit(0) as an unexpected
// termination otherwise. This is the case for Sentry.
NotificationCenter.default.post(name: UIApplication.willTerminateNotification, object: nil)

// Close the app after a slight delay so it has time to execute code for the notification
Expand Down