Fix xcframework linking. #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
ETTrace.xcframeworkbuilt as part of the CI pipeline can't be embedded into an app, as it results on missing symbols error.To fix this, it needs to embed or link any dependency that is needed for it to work.
This PR sets
SWIFT_PACKAGE_MANAGER_LINK_LIBRARIESandSWIFT_PACKAGE_MANAGER_EMBED_DEPENDENCIEStoYESon the xcodebuild command.I verified this works manually.
To repro, try using the
.xcframeworkon the release, then try the same thing by building and adding the xcframework to a project.