Skip to content

Conversation

runningcode
Copy link
Contributor

@runningcode runningcode commented Feb 20, 2025

This PR separates the test runner from the Mock Server and the Gradle Project.

This fixes a few things:

  • The new runner avoids using withPluginClasspath(). Using that method can be dangerous as it pollutes the classpath of the build under test with the test code and outer build.
  • Allow the test projects to be built dynamically using code to allow dyanmic version testing.
  • This also ensures that the MockServer is shut down even if the test fails.
  • Fixes broken github PR event tests.
  • Tests the code using logging output instead of writing to a file and deserializing it which should fix the broken tests in the shadow PR.

Copy link
Contributor Author

runningcode commented Feb 20, 2025

@runningcode runningcode force-pushed the no/use_simpleappbuilder branch from c79efbf to d1a4705 Compare February 20, 2025 08:48
Base automatically changed from no/remove_simple-agp-7.2.0_project_as_it_is_identical_to_simple_ to main February 20, 2025 09:19
@runningcode runningcode merged commit eff2111 into main Feb 21, 2025
4 checks passed
@runningcode runningcode deleted the no/use_simpleappbuilder branch February 21, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants