Feature/47 Bug Report #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haz un rebase de tu branch antes de continuar plz. Hicimos unos cambios. |
christianrd
force-pushed
the
feature/47-bug-report
branch
from
6c4c522
to
10842f5
Compare
| @@ -31,6 +32,7 @@ public static void Init(IConfiguration configuration, IServiceCollection service | |||
| //services.AddSingleton<IJobsService, MockJobsService>(); | |||
| services.AddSingleton<IHttpContextAccessor, HttpContextAccessor>(); | |||
| services.AddSingleton<ISlackService, SlackService>(); | |||
| services.AddSingleton<IReCaptchaService, ReCaptchaService>(); | |||
There was a problem hiding this comment.
Por que singleton? Siempre se necesita una instancia arriba para que funcione? Por que no scoped?
There was a problem hiding this comment.
Estaba pensando que se debería implementar el captcha en el wizard de crear vacante.
|
Anything to push this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
Visual aids
If there are visual changes include them here. You can add a screenshot or a recording using a tool like this one and include it in the Pull Request.
This is the markdown to include an image in the pull request:
You can include a comparison table as follows:
Issue: #47