Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tournament component#151 #186

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Tournament component#151 #186

merged 11 commits into from
Sep 23, 2024

Conversation

justin-b-yee
Copy link
Contributor

This implements the tournament component and stories to showcase it and its children's behavior.

@justin-b-yee justin-b-yee linked an issue Aug 11, 2024 that may be closed by this pull request
18 tasks
@justin-b-yee
Copy link
Contributor Author

Hi @ddfridley:

I was wondering where the roundsStatus data will come from (+ if the data's format will differ), and if we need to add a prop in Tournament to translate and pass that info to the RoundTracker?

<RoundTracker roundsStatus={['complete', 'inProgress', 'pending', 'pending', 'pending']} />

- Justin

@ddfridley
Copy link
Contributor

Good question. This question is touching on the area I am trying to work through. There will be a new api to "subscribe" to a discussion. This will get the round information, and some updates from the server like the number of participants, and the next available round. (can't go to round 2 until at least 100 people have gone through rounds 1. For round 3 it's 1000, etc. Also the initial subscription will ge the users status info. What round they last completed, etc. More to come.

@justin-b-yee
Copy link
Contributor Author

Just going to mark this for review for now - I believe there's adding the Review and Intermission components and updating the round tracker data left.

Copy link
Contributor

@ddfridley ddfridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so awesome to see this! All the pieces are coming together.

see in line comment about review and rank steps.

Also, in storybook, it's rendering a little too wide and so a horizontal scroll bar is showing up at the bottom, and you can scroll left/right be a few pixels.
This happens a lot, and it needs to be tracked down and fixed.
Sometimes setting box-sizing: border-box in the right place fixes it. Or sometimes left/right margin has to be removed. Please see if you can find it, if not we can try it together.

Thanks!

},
},
{
webComponent: 'ReviewPointList',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewPointList should be the Review step, the one before intermission.
RankStep should be the one that goes here. app/components/rank-step.jsx

@justin-b-yee
Copy link
Contributor Author

Also, in storybook, it's rendering a little too wide and so a horizontal scroll bar is showing up at the bottom, and you can scroll left/right be a few pixels.

I had to add layout: 'fullscreen' to the story in StepSlider for this same issue before, so I reapplied it here and the scrollbar seems to be gone now.

@ddfridley
Copy link
Contributor

When I run it and get to the Rank step I get blank and it's stuck, but what I saw on your screen worked through all the steps. Is something missing? Thanks.

image

@justin-b-yee
Copy link
Contributor Author

When I run it and get to the Rank step I get blank and it's stuck, but what I saw on your screen worked through all the steps. Is something missing? Thanks.

Hm, all my changes are pushed to this branch. When I get to RankStep the Next button is activated immediately for me, as in #193, a 0-point rankstep should call onDone true.

Copy link
Contributor

@ddfridley ddfridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Its great to see all this coming together.
I added some data to the rank step.
I see that there are issues where some components are taking props out of shared, while others don't. The original idea was that shared would be an object of the tournament component and the steps would take data out of it and put data into it. But with the refactor to using the deliberationContext all that will change so we don't need to refactor here.

Thanks!

@ddfridley ddfridley marked this pull request as ready for review September 23, 2024 21:03
@ddfridley ddfridley merged commit 85a9561 into master Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tournament Component
2 participants