Fix "invxf2" transfers leaving behind 1 item per stack#142
Open
Listerw wants to merge 1 commit intoEnderWiggin:masterfrom
Open
Fix "invxf2" transfers leaving behind 1 item per stack#142Listerw wants to merge 1 commit intoEnderWiggin:masterfrom
Listerw wants to merge 1 commit intoEnderWiggin:masterfrom
Conversation
Owner
|
Does this work when transferring ore to the smelter? |
Author
|
It works with transferring ore to the ore smelter. Trying with black coal, it's unchanged and still does nothing with this type of click when an ore smelter is open. If you are looking for cases where this doesn't work: having multiple target ExtInventory can still result in this issue. E.g. if you have 2 drying racks open and had a stack of 5 in your inventory, 4 will go to the first rack, then the item slot will become the unstacked version with a new id still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Results:
1 item will be left behind from the stack. This is likely due to transferring 1 item at a time, leading to a new id being created once there is only one item left in the stack, and so the previous id for that remaining item is no longer valid.
This fixes it by sending the stack size when transferring each item. It only needs to be done once per item in the stack, but I couldn't see an easy way to do it. E.g. see Cediner/ArdClient#104
I've tested this by building locally and transferring stacks of different sizes + an unstacked item using the extra info panel into a stockpile.