Update Microcontroladores.hs #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +98,14 @@ debug = filter (not.aBug) | |||
| aBug :: Instruccion -> Bool | |||
| aBug f = (==0).sum.(++ [a.f $ xt8088]).(++ [b.f $ xt8088]).memoria.f $ xt8088 | |||
|
|
|||
| memoriaOrdenada :: Micro -> Bool | |||
| memoriaOrdenada (Micro (x:xs) a b pc e p) | |||
| | emptyMemo.memoria = true | |||
There was a problem hiding this comment.
Esta linea tiene 2 errores:
- memoria es una funcion que recibe un Micro y devuelve una lista, en este caso no le estas pasando ningun parametro.
- En el caso de que le pases un Micro tambien estaria mal porque emptyMemo recibe un Micro no una lista.
| memoriaOrdenada :: Micro -> Bool | ||
| memoriaOrdenada (Micro (x:xs) a b pc e p) | ||
| | emptyMemo.memoria = true | ||
| | xs < ultimo x = memoriaOrdenada (Micro x a b pc e p) |
There was a problem hiding this comment.
Aca entiendo que lo que quisiste hacer es:
x < ultimo xs
de todas formas la funcion ultimo que definiste hace lo mismo que tail, si le queres dar un alias podrias hacer
ultimo = tail
El enunciado dice que las celdas de memoria tienen que ser menores o iguales, faltaria el caso de cuando son iguales.
ademas, en memoriaOrdenada estas comparando un elemento de la memoria con el siguiente, pero yo entiendo que hay que compararlo con todos los elementos que le siguen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.5