quite local #168
quite local #168
Conversation
WalkthroughThis pull request introduces comprehensive localization updates for the Russian language across multiple game files. The changes primarily focus on adding new entries for the precognition power, weapon descriptions, station event systems, and various paper-related items. The modifications enhance the game's Russian language support by providing translations for new game elements, including detailed descriptions of psionic abilities, weapon names, and miscellaneous in-game items. Changes
Sequence DiagramsequenceDiagram
participant Player
participant PrecognitionPower
participant GameEvents
Player->>PrecognitionPower: Activate
PrecognitionPower->>GameEvents: Request Future Event
GameEvents-->>PrecognitionPower: Return Potential Event
PrecognitionPower->>Player: Display Localized Event Description
Possibly related PRs
Suggested Labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🔭 Outside diff range comments (1)
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Battery/battery_guns.yml (1)
Balance adjustments needed for new beam weapons
The verification confirms significant balance concerns:
- The beam devastator's charge capacity (300,000) is 100-600x higher than other weapons (500-3,000)
- Both weapons have the highest fire rate (15) compared to others (1.5-3)
- The beam devastator's fire cost (600) is 6x higher than standard weapons (50-100)
- The beam cannon's fire cost (10) is unusually low compared to others
Recommendations:
- Reduce beam devastator's charge capacity to ~5,000-10,000
- Lower fire rates to 3-5 for better balance with existing weapons
- Adjust beam cannon's fire cost to at least 50-100
- Consider unique sound effects for weapon differentiation
🔗 Analysis chain
Line range hint
293-385: Review weapon balance for new beam weaponsThe beam weapons, particularly the beam devastator, have some potential balance concerns:
- The beam devastator's charge capacity (300000) is significantly higher than other weapons (typically 500-3000)
- Both weapons share the same fire rate (15) and sound effects
- The beam devastator's fire cost (600) might deplete too quickly or too slowly given the massive charge capacity
Consider:
- Adjusting the charge capacity to be more in line with other weapons
- Differentiating the weapons' fire rates and sound effects
- Documenting the intended balance rationale
The results confirm the significant charge capacity disparity and shared sound effects. Let me verify the fire rates and costs of other weapons for a complete balance comparison.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Compare with other weapon configurations to verify balance rg "maxCharge: \d+" Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Battery/ # Check for weapon sound effect reuse rg "path: .*beamcannon.ogg" Resources/Prototypes/Length of output: 1153
Script:
#!/bin/bash # Check fire rates and costs of other battery weapons rg "fireRate: \d+" Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Battery/ rg "fireCost: \d+" Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Battery/Length of output: 2303
🧹 Nitpick comments (2)
Resources/Locale/ru-RU/deltav/abilities/psionic.ftl (2)
39-42: Fix inconsistent punctuationThe following messages are missing periods at the end, unlike other messages in the file:
- mouse-migration-result-message
- cockroach-migration-result-message
- snail-migration-result-message
Add periods to maintain consistency with other messages:
-Вы видите видение жизни как примитивного существа, снующего под ногами существ, превосходящих ваше понимание +Вы видите видение жизни как примитивного существа, снующего под ногами существ, превосходящих ваше понимание.
4-46: Consider standardizing narrative perspectiveThe messages switch between different narrative styles:
- Direct vision descriptions: "Вы видите видение..."
- Immediate experience descriptions: "Реальность вокруг вас выпирает..."
- Second-person observations: "Ваш коллега лежит..."
While the variations add flavor, consider standardizing the perspective for better consistency and immersion.
Consider adopting a consistent narrative style, preferably the "Вы видите видение..." format, as it better reflects the precognitive nature of the ability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
Resources/Locale/ru-RU/deltav/abilities/powers.ftl(1 hunks)Resources/Locale/ru-RU/deltav/abilities/psionic.ftl(1 hunks)Resources/Locale/ru-RU/deltav/research/technologies.ftl(1 hunks)Resources/Locale/ru-RU/deltav/station-events/station-event-system.ftl(1 hunks)Resources/Locale/ru-RU/deltav/weapons/ranged/energygun.ftl(1 hunks)Resources/Locale/ru-RU/paper/paper-misc.ftl(1 hunks)Resources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/misc/paper.ftl(1 hunks)Resources/Prototypes/DeltaV/Actions/types.yml(3 hunks)Resources/Prototypes/DeltaV/Catalog/Fills/Paper/manuals.yml(3 hunks)Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Battery/battery_guns.yml(2 hunks)
✅ Files skipped from review due to trivial changes (2)
- Resources/Locale/ru-RU/deltav/weapons/ranged/energygun.ftl
- Resources/Prototypes/DeltaV/Actions/types.yml
🔇 Additional comments (7)
Resources/Prototypes/DeltaV/Catalog/Fills/Paper/manuals.yml (2)
Line range hint 9-27: LGTM! Well-structured entity definitions for mom's notes.
The new entities follow proper inheritance patterns and maintain consistent structure with the parent entity.
31-32: Verify localization key references.
The entity now references gorlax-girlfriend-name and gorlax-girlfriend-desc localization keys. Let's verify these keys exist in all supported languages to avoid missing translations.
Resources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/misc/paper.ftl (1)
66-67: LGTM! Translations are consistent with existing entries.
The Russian translations for the subscription notice maintain the same style and format as other entries in the file.
Resources/Locale/ru-RU/paper/paper-misc.ftl (1)
75-83: LGTM! Well-structured and properly formatted content.
The subscription notice content is well-organized with appropriate use of formatting tags and maintains thematic consistency with the Syndicate-sponsored content mentioned in the PR objectives.
A few positive notes:
- Good use of BBCode formatting for headers and colors
- Proper spacing between paragraphs
- Consistent tone throughout the content
- Color choice (#780606) aligns well with the Syndicate theme
Resources/Locale/ru-RU/deltav/abilities/powers.ftl (1)
1-2: Translations are accurate and well-integrated.
The Russian translations for the precognition power name and description are accurate and natural-sounding while maintaining the original meaning.
✅ Verification successful
The previous ast-grep pattern wasn't suitable for FTL files. Let's search for the actual strings and related power entries to verify the integration.
Let's examine the psionic ability files to verify how the precognition power is integrated with the psionic system, as these files were found in our previous search.
Translations are properly integrated with the psionic system
The search results confirm that the precognition power translations are well-integrated into the game's psionic system. The translations in powers.ftl are referenced extensively in psionic.ftl for various precognition event messages, with both English and Russian translations properly maintained. The translations are consistent across the system and follow the established localization patterns.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the power name and description are properly referenced in action types
ast-grep --pattern 'power-precognition-name|power-precognition-desc'
Length of output: 70
Script:
#!/bin/bash
# Search for files containing precognition-related strings
rg -l "precognition|Предсказание" --type-add 'ftl:*.ftl' --type ftl
# Search for any power-related strings in FTL files to understand the pattern
rg "power-.*-name" --type-add 'ftl:*.ftl' --type ftl
Length of output: 1217
Script:
#!/bin/bash
# Let's check the content of psionic files that reference precognition
rg -A 2 "precognition|Предсказание" Resources/Locale/ru-RU/deltav/abilities/psionic.ftl Resources/Locale/en-US/deltav/abilities/psionic.ftl
# Check for any power-related strings in these specific files
rg "power-" Resources/Locale/ru-RU/deltav/abilities/psionic.ftl Resources/Locale/en-US/deltav/abilities/psionic.ftl
Length of output: 40798
Resources/Locale/ru-RU/deltav/abilities/psionic.ftl (2)
1-3: Core messages look good!
The basic system messages are well-translated and maintain their functional purpose while being grammatically correct.
1-46: Verify translation coverage
Let's ensure all game events have corresponding translations.
| name: weapon-ice-name | ||
| description: weapon-ice-desc |
There was a problem hiding this comment.
💡 Codebase verification
Add English translations for the cold cannon weapon
The localization keys are only defined in Russian (ru-RU) but missing in other locales, particularly English. Add the following translations to the English locale file:
weapon-ice-nameweapon-ice-desc
🔗 Analysis chain
Verify localization keys for the cold cannon weapon
The change to use localization keys (weapon-ice-name and weapon-ice-desc) aligns with the PR's translation objectives. However, we should verify these keys exist in the localization files.
Localization keys for cold cannon weapon are properly defined
The localization keys weapon-ice-name and weapon-ice-desc are correctly defined in the Russian locale file at Resources/Locale/ru-RU/deltav/weapons/ranged/energygun.ftl. Let's verify if they are also defined in other locales for completeness.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the localization keys exist in the Russian locale files
rg "weapon-ice-(name|desc)" Resources/Locale/ru-RU/
Length of output: 235
Script:
#!/bin/bash
# Check if the localization keys exist in other locale files
rg "weapon-ice-(name|desc)" Resources/Locale/
Length of output: 229
| @@ -0,0 +1 @@ | |||
| station-event-system-run-event-delayed = {$eventName} начнётся через {$seconds} секунд | |||
There was a problem hiding this comment.
💡 Codebase verification
Translation needs adjustment for proper plural forms
The Russian translation should handle plural forms for the word "секунд" (seconds) based on the number value, similar to other translations in the codebase. Here's what needs to be fixed:
Resources/Locale/ru-RU/deltav/station-events/station-event-system.ftl: Update to use proper plural forms:
station-event-system-run-event-delayed = {$eventName} начнётся через {$seconds} {$seconds ->
[one] секунду
[few] секунды
*[other] секунд
}
🔗 Analysis chain
Translation looks good and maintains proper placeholder usage.
The Russian translation correctly handles the event notification format while maintaining proper grammar structure. The placeholders {$eventName} and {$seconds} are preserved correctly.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify consistent placeholder usage across other event system translations
rg -g '*.ftl' '\$eventName|\$seconds' Resources/Locale/
Length of output: 4376
|
|
||
| research-technology-ionized-cryogenic-emission-equipment = Оборудование ионной заморозки |
There was a problem hiding this comment.
💡 Codebase verification
Based on the script results, I can generate the final response since I have sufficient information to verify the review comment:
Translations and formatting need attention
The file Resources/Locale/ru-RU/deltav/research/technologies.ftl is missing a trailing newline, which is inconsistent with proper file formatting standards. However, the translation style is consistent with other technology entries in the codebase, following similar patterns for weapon and equipment translations.
- Add a trailing newline at the end of
Resources/Locale/ru-RU/deltav/research/technologies.ftl
🔗 Analysis chain
Translations and formatting are correct.
The new translations maintain consistency with existing technology entries. The added newline ensures proper file formatting.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify consistent newline usage in FTL files
rg -l '[^\n]\z' Resources/Locale/ru-RU/deltav/**/*.ftl
# Verify consistent translation style across technology entries
rg -g '*.ftl' '^research-technology-' Resources/Locale/ru-RU/
Length of output: 11086
| psionic-power-precognition-xeno-vents-result-message = Вы видите видение, выглядывая из-за угла, вы видите, как странный, хлюпающий зверь разрывает внутренности одного из ваших коллег, когда он издает душераздирающий крик. | ||
| psionic-power-precognition-mothroach-spawn-result-message = Вы видите видение, выглядывая из-за угла, вы видите, как странный, хлюпающий зверь разрывает внутренности одного из ваших коллег, когда он издает душераздирающий крик. |
There was a problem hiding this comment.
Fix duplicate message content
The messages for xeno-vents-result-message and mothroach-spawn-result-message are identical. This appears to be a copy-paste error as they should describe different events.
Please provide distinct descriptions for each event type.
О чем PR
Перевод журанала "ДЕВОЧКИ ГОРЛАКСА" ❤️🔥, новой пси-способки (без перевода она была бы юзлесс) и криопушки
Почему
Технические детали
Медиа
Summary by CodeRabbit