fix: changes based on feedback

EnergySage · Sep 17, 2024 · 6bdf665 · 6bdf665
1 parent 6b079b0
commit 6bdf665
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/es-ds-components/components/es-rating.vue b/es-ds-components/components/es-rating.vue
@@ -87,10 +87,6 @@ const update = (value: number) => {
     </div>
     <rating
         v-else
-        role="slider"
-        aria-valuemin="1"
-        aria-valuemax="5"
-        :aria-valuenow="roundedRating"
         :model-value="roundedRating"
         :cancel="false"
         :readonly="readOnly"

diff --git a/es-ds-docs/pages/molecules/rating.vue b/es-ds-docs/pages/molecules/rating.vue
@@ -1,4 +1,5 @@
 <script setup lang="ts">
+// Event will trigger twice when using keyboard to focus due to PrimeVue bug
 const changeEvent = ($event) => {
     // eslint-disable-next-line no-alert
     alert($event.value);