chore: use the correct node versions in ci and deploy, align npm inst…

…allation process
EnergySage · Sep 18, 2024 · ab114e6 · ab114e6
1 parent 6b587f5
commit ab114e6
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 16 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,25 +13,25 @@ on:
 
 jobs:
     ci:
-        runs-on: ${{ matrix.os }}
-
-        strategy:
-            matrix:
-                os: [ubuntu-latest]
-                node: [16]
+        runs-on: ubuntu-latest
 
         steps:
             - name: Checkout 🛎
-              uses: actions/checkout@master
+              uses: actions/checkout@v4
+
+            - name: Get nodenv version 🔌
+              id: nodenv
+              shell: bash
+              run: echo "node-version=$(cat .node-version)" >> $GITHUB_OUTPUT
 
             - name: Setup node env 🏗
-              uses: actions/setup-node@v3.7.0
+              uses: actions/setup-node@v4
               with:
-                  node-version: ${{ matrix.node }}
+                  node-version: '${{ steps.nodenv.outputs.node-version }}'
                   check-latest: true
 
             - name: Cache node_modules 📦
-              uses: actions/cache@v3.3.1
+              uses: actions/cache@v4
               with:
                   path: ~/.npm
                   key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

diff --git a/.github/workflows/deploy-v3.yml b/.github/workflows/deploy-v3.yml
@@ -31,19 +31,35 @@ jobs:
               run: |
                   aws codeartifact login --tool npm --domain energysage --domain-owner 659694780082 --repository cloud-engineering
 
-            - name: Link ES-DS Version 3 🔗
-              working-directory:
+            - name: Get nodenv version 🔌
+              id: nodenv
               shell: bash
+              run: echo "node-version=$(cat .node-version)" >> $GITHUB_OUTPUT
+
+            - name: Setup node env 🏗
+              uses: actions/setup-node@v4
+              with:
+                  node-version: '${{ steps.nodenv.outputs.node-version }}'
+                  check-latest: true
+
+            - name: Cache node_modules 📦
+              uses: actions/cache@v4
+              with:
+                  path: ~/.npm
+                  key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+                  restore-keys: |
+                      ${{ runner.os }}-node-
+
+            - name: Install dependencies 👨🏻‍💻
               run: |
-                cd es-ds-styles; npm link
-                cd ../es-ds-components; npm link
-                cd ../es-ds-docs; npm link @energysage/es-ds-styles @energysage/es-ds-components
+                make install
+                make symlink
 
             - name: Build ES-DS Version 3 🛠️
               working-directory: ./es-ds-docs
               shell: bash
               run: |
-                npx nuxt generate
+                npm run generate
 
             - name: Deploy to S3 📍
               working-directory: ./es-ds-docs