Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CED-1824 Fix warning about color-adjust in the Vue 3 design system #1500

Merged
merged 1 commit into from
Aug 29, 2024
Merged

CED-1824 Fix warning about color-adjust in the Vue 3 design system #1500

merged 1 commit into from
Aug 29, 2024

Conversation

tomleo
Copy link
Member

@tomleo tomleo commented Aug 29, 2024

🔗 Linked issue

https://energysage.atlassian.net/browse/CED-1824

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

🥼 Testing

  • Ran make dev and saw the error went away

🧐 Feedback Requested / Focus Areas

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@tomleo tomleo changed the base branch from main to esds-3.0-vue3-primevue August 29, 2024 01:44
nathanielwarner
nathanielwarner approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! No more warnings! 🎉

@tomleo tomleo merged commit 2ff5d16 into esds-3.0-vue3-primevue Aug 29, 2024
1 check passed
@tomleo tomleo deleted the CED-1824 branch August 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielwarner nathanielwarner nathanielwarner approved these changes

@ericdouglaspratt ericdouglaspratt Awaiting requested review from ericdouglaspratt ericdouglaspratt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomleo @nathanielwarner