Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CED-1756 V3 EsSupport #1511

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Conversation

lgeggleston
Copy link
Contributor

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-1756

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added v3 component and docs page for es-support

  • No PrimeVue component was used
  • Simplified and removed unused prop (variant), unnecessary styles and classes.

πŸ₯Ό Testing

  • Replicate API from original component and tested with real image as well as placeholder.

🧐 Feedback Requested / Focus Areas

  • I used a simple <img> tag because I don't think this particular image requires any bells and whistles, and PrimeVue components such as Image and Avatar both added complication in this case. Any objections to this implementation?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@nathanielwarner
Copy link
Collaborator

πŸ‘€

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸš€

@lgeggleston lgeggleston merged commit 9c163d9 into esds-3.0-vue3-primevue Sep 5, 2024
1 check passed
@lgeggleston lgeggleston deleted the CED-1756-v3-es-support branch September 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants