-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ced 1746 es carousel #1512
Ced 1746 es carousel #1512
Conversation
π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few comments inline.
Also I think a Carousel might be better categorized as an Organism given it's composed of other molecules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one suggestion at this point is to add primevue/carousel
to the optimizeDeps
in the nuxt config in es-ds-components
, to stop the annoying auto-refresh while loading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the cats! Other than merge conflicts, I think the issues you identified are the only ones I see. Do you think it's gonna be possible to address them with the PrimeVue carousel? I guess it's a product question as to whether it's acceptable, but they don't affect our current carousels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only question is where nuxt/image
should live (in the layer or in the docs)
I think it could be possible with more investigation, and I'm also curious to see if it's improved in the next version. |
π Linked issue
https://energysage.atlassian.net/browse/CED-1746
β Type of change
π Description
Putting a PR up to get initial feedback on the new EsCarousel component that uses PrimeVue's Carousel. I'm still working on getting a few things working (see Feedback section).
π₯Ό Testing
Tested locally on http://localhost:8500/molecules/carousel - rotated through the carousel on different viewports and pausing autoplay
π§ Feedback Requested / Focus Areas
A few known issues:
circular
π Checklist