-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add EsFormTextarea v3 #1519
Conversation
β
Β Linked to Task CED-1758 Β· Create EsFormTextarea using PrimeVue |
π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Just a cleanup and a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just the one nit.
π Linked issue
https://energysage.atlassian.net/browse/CED-1758
β Type of change
π Description
Adds molecule
EsFormTextarea
based off of existing implementation that uses HTML elementtextarea
. I initially tried using PrimeVue'sTextarea
component but the unstyled mode is essentially the same astextarea
.π₯Ό Testing
Tested locally at http://localhost:8500/molecules/form-textarea ensuring the entered value propagates across all input fields, excluding the success state fields which have their own message
π§ Feedback Requested / Focus Areas
v-bind="$attrs"
but ended up usingmodelValue
when that worked with neitherTextarea
nortextarea
π Checklist