Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EsFormTextarea v3 #1519

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Conversation

hroth1994
Copy link
Contributor

@hroth1994 hroth1994 commented Sep 10, 2024

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-1758

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds molecule EsFormTextarea based off of existing implementation that uses HTML element textarea. I initially tried using PrimeVue's Textarea component but the unstyled mode is essentially the same as textarea.

πŸ₯Ό Testing

Tested locally at http://localhost:8500/molecules/form-textarea ensuring the entered value propagates across all input fields, excluding the success state fields which have their own message

🧐 Feedback Requested / Focus Areas

  • A few things to note:
  • I tried v-bind="$attrs" but ended up using modelValue when that worked with neither Textarea nor textarea
  • hover, active, and focus pseudo-classes match existing implementation rather than ESDS 2.0 design
  • border width matches design, not existing implementation (existing: .556px, ESDS 2.0 design: 1px)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Sep 10, 2024

βœ… Β Linked to Task CED-1758 Β· Create EsFormTextarea using PrimeVue
➑️  Part of Epic CED-1339 · Build Vue 3 design system [LC]

@nathanielwarner
Copy link
Collaborator

πŸ‘€

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a cleanup and a fix.

es-ds-components/components/es-form-textarea.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/form-textarea.vue Outdated Show resolved Hide resolved
es-ds-docs/components/ds-molecules-list.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the one nit.

es-ds-components/components/es-form-textarea.vue Outdated Show resolved Hide resolved
@hroth1994 hroth1994 merged commit 626a831 into esds-3.0-vue3-primevue Sep 13, 2024
1 check passed
@hroth1994 hroth1994 deleted the ced-1758-es-form-textarea branch September 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants