CED-1762 create v3 EsViewMore

[lgeggleston]

🔗 Linked issue

https://energysage.atlassian.net/browse/CED-1762

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

• Create EsViewMore in Vue 3, no need for primeVue component
• install dependency html-truncate
• Removed a piece of logic from original version of this component that seems to pass down click functionality from the parent if given and replace default show more/show less (if (this.$listeners && this.$listeners.click) ...). However, a check through ES repo usage of this component showed this is not currently used, and I don't think it makes much sense to continue, so removed in this case..
  • Update: see Feedback for reasoning
  • To note: after looking into migrating this bit to Vue3 it also seems either deprecated or messy to work around: $attrs no longer contains events declared in the emits option vuejs/rfcs#397

🥼 Testing

🧐 Feedback Requested / Focus Areas

• The click override thing is actually used for a real reason in one place - EsReview ( to open a modal in CDGM). However, we decided to defer recreating EsReview since it's only used in CDGM for now. I think it may actually be simpler to replace that use in EsReview with a truncated span+button, since that's the only part of the component really used - but we only need to do that if CDGM is getting upgraded to vue3 at all.
  • does it sounds alright if I just add this note to the Review ticket, in case gets done in the future?

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.
• I have documented testing approach

[swarmia]

✅  Linked to Task CED-1762 · Create v3 EsViewMore
➡️  Part of Epic CED-1339 · Build Vue 3 design system [LC]

[hroth1994]

👀

[hroth1994]

Looks great so far! Just a few non-functional comments:

[hroth1994]

I agree adding a note to the EsReview ticket is sufficient. One small nit but LGTM! 🌟