-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CED-1827: update dependencies and fix vulnerabilities #1521
Merged
nathanielwarner
merged 11 commits into
esds-3.0-vue3-primevue
from
CED-1827-update-deps
Sep 11, 2024
Merged
CED-1827: update dependencies and fix vulnerabilities #1521
nathanielwarner
merged 11 commits into
esds-3.0-vue3-primevue
from
CED-1827-update-deps
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit da98c7a.
nathanielwarner
requested review from
tomleo and
ericdouglaspratt
as code owners
September 10, 2024 19:55
β
Β Linked to Task CED-1827 Β· [Timebox] Audit and update out of date dependencies in Vue 3 design system |
π @nathanielwarner please resolve conflicts |
# Conflicts: # es-ds-components/package-lock.json # es-ds-components/package.json
RANE1021
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
https://energysage.atlassian.net/browse/CED-1827
β Type of change
π Description
es-ds-styles
.npm audit fix
was run, which made some automated upgrades. Other vulnerabilities were fixed by manually evaluating the dependency, removing the dependency if it's no longer used (due to no longer having the Bootstrap JavaScript), or updated to a new major version otherwise.es-ds-components
andes-ds-docs
.π₯Ό Testing
I ran the
npm run build
andnpm run test
withines-ds-styles
to make sure that these utilities were not broken by doing the major updates and removals. I tested the dev server fores-ds-docs
, as well as static generation.π§ Feedback Requested / Focus Areas
π Checklist