Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CED-1827: update dependencies and fix vulnerabilities #1521

Merged
merged 11 commits into from
Sep 11, 2024

Conversation

nathanielwarner
Copy link
Collaborator

@nathanielwarner nathanielwarner commented Sep 10, 2024

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-1827

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Fixes vulnerable dependencies in es-ds-styles. npm audit fix was run, which made some automated upgrades. Other vulnerabilities were fixed by manually evaluating the dependency, removing the dependency if it's no longer used (due to no longer having the Bootstrap JavaScript), or updated to a new major version otherwise.
  • Update the Vue version in es-ds-components and es-ds-docs.
  • Homepage of docs is updated to include link to examples, and more accurately describe relationship with PrimeVue.

πŸ₯Ό Testing

I ran the npm run build and npm run test within es-ds-styles to make sure that these utilities were not broken by doing the major updates and removals. I tested the dev server for es-ds-docs, as well as static generation.

🧐 Feedback Requested / Focus Areas

  • General

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Sep 10, 2024

@RANE1021
Copy link
Contributor

πŸ‘€ @nathanielwarner please resolve conflicts

# Conflicts:
#	es-ds-components/package-lock.json
#	es-ds-components/package.json
Copy link
Contributor

@RANE1021 RANE1021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielwarner nathanielwarner merged commit 34d0a9c into esds-3.0-vue3-primevue Sep 11, 2024
1 check passed
@nathanielwarner nathanielwarner deleted the CED-1827-update-deps branch September 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants