Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CED-1754 Create v3 EsFormRadioCards #1525

Merged
merged 30 commits into from
Sep 18, 2024
Merged

CED-1754 Create v3 EsFormRadioCards #1525

merged 30 commits into from
Sep 18, 2024

Conversation

tomleo
Copy link
Member

@tomleo tomleo commented Sep 12, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Refactored es-radio-button and es-radio-button-group to use the native input element, and reverted es-ds-styles back to what they were previously. This fixes styling issues when apply shared styles to the card components.
  • The cards markup wrap is essentially <label><input /></lable> whereas the button markup is basically <label for="" /><input />. Implementing es-form-radio-card and es-form-radio-cards components also using the native input element greatly simplifies things.
  • Added disabled styling per figma https://www.figma.com/design/G3Zq89yg3vek9b4JrnlSYn/ESDS-2.0?node-id=16626-2752&node-type=frame&t=H4B3RvLBrv6G7Dad-0

πŸ₯Ό Testing

Manual

🧐 Feedback Requested / Focus Areas

  • The previous implementation allowed for v-model to be set in the wrapping component when also adding radio-cards as slots. I could not figure out how to make this work (aside from a provide/inject implementation that broke other things). It seems like a reasonable trade-off to define a v-model on input fields when you define them, or use v-model on the group component when passing in an options array.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Sep 12, 2024

βœ… Β Linked to Task CED-1754 Β· Create v3 EsFormRadioCards
➑️  Part of Epic CED-1339 · Build Vue 3 design system [MC]

@nathanielwarner
Copy link
Collaborator

@tomleo could you resolve merge conflicts and apply the prism fix?

@nathanielwarner
Copy link
Collaborator

πŸ‘€

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! My comments are mostly geared towards cleaning up the code and setting up downstream repos for success.

es-ds-components/components/es-form-radio-cards.vue Outdated Show resolved Hide resolved
es-ds-docs/components/ds-molecules-list.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/radio-button.vue Show resolved Hide resolved
es-ds-docs/pages/molecules/radio-button-new.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/radio-cards.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/radio-cards.vue Outdated Show resolved Hide resolved
es-ds-components/components/es-form-radio-cards.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/radio-cards.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/radio-cards.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! mainly should just address the focus state of the radio cards

es-ds-docs/pages/molecules/radio-cards.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/radio-cards.vue Outdated Show resolved Hide resolved
es-ds-components/components/es-form-radio-cards.vue Outdated Show resolved Hide resolved
@tomleo
Copy link
Member Author

tomleo commented Sep 18, 2024

Almost there! mainly should just address the focus state of the radio cards

Yes! Done via 1c3d672

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸš€

@tomleo tomleo merged commit 3089749 into esds-3.0-vue3-primevue Sep 18, 2024
1 check passed
@tomleo tomleo deleted the CED-1754 branch September 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants