Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CED-1789: file preview modal #1528

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

nathanielwarner
Copy link
Collaborator

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-1789

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Implements es-file-preview-modal. Mostly copied over from the old design system and switched to the composition API. es-modal needed to be tweaked in order to apply all the necessary styling. Also found and fixed an accessibility issue with the modal.

πŸ₯Ό Testing

Manual testing on http://localhost:8500/organisms/file-preview-modal

🧐 Feedback Requested / Focus Areas

  • General

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Sep 13, 2024

βœ… Β Linked to Task CED-1789 Β· Create v3 EsFilePreviewModal
➑️  Part of Epic CED-1339 · Build Vue 3 design system [MC]

@mpleroux
Copy link
Member

πŸ‘€

Copy link
Member

@mpleroux mpleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modal looks good when I test it locally. Thanks for adding the extra props and documenting them.

Were those selectors you removed from _modal.scss no longer needed, or never used in the first place?

@nathanielwarner
Copy link
Collaborator Author

Were those selectors you removed from _modal.scss no longer needed, or never used in the first place?

They were used in the BootstrapVue implementation, but not with the PrimeVue one.

@nathanielwarner nathanielwarner merged commit 90c9779 into esds-3.0-vue3-primevue Sep 16, 2024
1 check passed
@nathanielwarner nathanielwarner deleted the CED-1789-file-preview branch September 16, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants