-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CED-1790 create v3 EsZipCodeForm #1529
CED-1790 create v3 EsZipCodeForm #1529
Conversation
β
Β Linked to Task CED-1790 Β· Create v3 EsZipCodeForm |
π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good π
One possible tweak with v-model on the input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
π Linked issue
https://energysage.atlassian.net/browse/CED-1790
β Type of change
π Description
EsFormInput
-inheritAttrs: false
previously did not include classes but does now, and the zip code form needs to pass some classes to the input-wrapper. I added a workaround to enable in this casevuelidateInteger
, because the updated version now allows decimals withvuelidateNumber
which does make sense, this is more specificπ₯Ό Testing
zipCodeValue
via a timeout to set it on the docs pageπ§ Feedback Requested / Focus Areas
invalid
, because it didn't seem to have an effect or be styled anywhere now, perhaps replaced byis-invalid
on form input. Would love a 2nd opinion on this howeverπ Checklist