Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CED-1790 create v3 EsZipCodeForm #1529

Merged

Conversation

lgeggleston
Copy link
Contributor

@lgeggleston lgeggleston commented Sep 16, 2024

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-1790

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Recreated EsZipCodeForm for vue 3
  • Note: One change from Vue 2 showed up in EsFormInput - inheritAttrs: false previously did not include classes but does now, and the zip code form needs to pass some classes to the input-wrapper. I added a workaround to enable in this case
  • Note: Added vuelidateInteger, because the updated version now allows decimals with vuelidateNumber which does make sense, this is more specific

πŸ₯Ό Testing

  • Tested watcher on zipCodeValue via a timeout to set it on the docs page
  • basic a11y testing for keyboard navigation and aria attributes

🧐 Feedback Requested / Focus Areas

  • I removed the class invalid, because it didn't seem to have an effect or be styled anywhere now, perhaps replaced by is-invalid on form input. Would love a 2nd opinion on this however

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Sep 16, 2024

βœ… Β Linked to Task CED-1790 Β· Create v3 EsZipCodeForm
➑️  Part of Epic CED-1339 · Build Vue 3 design system [MC]

@tomleo
Copy link
Member

tomleo commented Sep 16, 2024

πŸ‘€

@tomleo
Copy link
Member

tomleo commented Sep 16, 2024

This isn't a regression as this behavior matches what we had before, but the side-by-side doesn't seem to be optimal in mobile

Screenshot 2024-09-16 at 10 24 45β€―AM

Copy link
Member

@tomleo tomleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good πŸ‘

One possible tweak with v-model on the input

@lgeggleston
Copy link
Contributor Author

This isn't a regression as this behavior matches what we had before, but the side-by-side doesn't seem to be optimal in mobile

That's a fair point for this example in the docs page, but I'm going to say this is a use case that should still be supported. The stackUntil just allows any viewport to be entered so it's up to the instance to set it at a viewport that makes sense; and there's a possibility it can look fine side-by-side on mobile if someone wants a short button text:
Screenshot 2024-09-18 at 11 49 14β€―AM
I updated the docs page button to that so that it makes more sense.

Copy link
Member

@tomleo tomleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@lgeggleston lgeggleston merged commit f9b9ef4 into esds-3.0-vue3-primevue Sep 30, 2024
1 check passed
@lgeggleston lgeggleston deleted the CED-1790-create-v-3-es-zip-code-form branch September 30, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants