Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CED-1857: accessibility dod #1530

Merged
merged 1 commit into from
Sep 18, 2024
Merged

CED-1857: accessibility dod #1530

merged 1 commit into from
Sep 18, 2024

Conversation

nathanielwarner
Copy link
Collaborator

🔗 Linked issue

https://energysage.atlassian.net/browse/CED-1857

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add accessibility definition of done to the PR template. Removes some things that are redundant or irrelevant.

🥼 Testing

N/A

🧐 Feedback Requested / Focus Areas

  • General

📝 Checklist

  • I have verified accessibility of any new components by:
    • automated check with the WAVE browser extension
    • navigating by keyboard
    • using with a screen reader (e.g. VoiceOver on Safari)
  • I have included any Storyblok component schema updates.
  • I have updated any applicable documentation.

@swarmia Swarmia
Copy link

swarmia bot commented Sep 18, 2024

✅  Linked to Task CED-1857 · Add accessibility DoD to all Confluence docs and CED repos

tomleo
tomleo approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@tomleo tomleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nathanielwarner nathanielwarner merged commit 1bfc1f6 into esds-3.0-vue3-primevue Sep 18, 2024
1 check passed
@nathanielwarner nathanielwarner deleted the CED-1857-accessibility-dod branch September 18, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleo tomleo tomleo approved these changes

@ericdouglaspratt ericdouglaspratt Awaiting requested review from ericdouglaspratt ericdouglaspratt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanielwarner @tomleo