Ratings Tweaks #1531
Open
Ratings Tweaks #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomleo
requested review from
ericdouglaspratt and
nathanielwarner
as code owners
|
✅ Linked to Task CED-1822 · EsRating follow-up TODOs |
hroth1994
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Mentioned this on Slack - the change event is still triggering twice, you just can't tell anymore without the alert. I do like the new experience in your PR, but I'm not sure removing the alert is ideal since it's a good way of observing that PrimeVue has this issue
| <es-rating :rating="4.5" /> | ||
|
|
||
| <div class="my-500"> | ||
| <h2>Background Variations</h2> |
There was a problem hiding this comment.
Sentence case - Background variations
| </script> | ||
|
|
||
| <template> | ||
| <div | ||
| v-if="readOnly" | ||
| :aria-label="`${roundedRating} out of 5 stars`" | ||
| v-if="props.readOnly" |
There was a problem hiding this comment.
You don't need props. and can use the props explicitly
|
@tomleo can you add the PR description and address formatting errors? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mehhh