Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo update (2024-12) #609

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Cargo update (2024-12) #609

merged 4 commits into from
Dec 7, 2024

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Dec 7, 2024

No description provided.

@qarmin
Copy link

qarmin commented Dec 7, 2024

There is even more things to update

cargo +nightly -Z unstable-options update --breaking
cargo update

found also

   Upgrading ndarray ^0.15.1 -> ^0.16.1
   Upgrading jxl-oxide ^0.9.1 -> ^0.10.2

Rustrover shows several unused crates

devtools/dictionary-builder/Cargo.toml -> serder_json
parser/Cargo.toml -> chrono
scpproxy/Cargo.toml -> dicom-dictorionary-std
ul/Cargo.toml -> dicom-core

Also 2 files are not used

transfer-syntax-registry/src/deflate.rs

and

object/src/attribute.rs

@Enet4
Copy link
Owner Author

Enet4 commented Dec 7, 2024

OK, I will see what can be further updated.

   Upgrading ndarray ^0.15.1 -> ^0.16.1

This is a breaking change because ndarray is part of the dicom-pixel-data public API. We can keep the update ready, but it likely won't enter before 0.9.0.

   Upgrading jxl-oxide ^0.9.1 -> ^0.10.2

This is something that we probably can update right away, but there are updates to the API which I believe dicom-transfer-syntax-registry can take advantage of, so it is better off handled in a separate PR.

devtools/dictionary-builder/Cargo.toml -> serder_json

Granted, this was probably a partial realization of the intent to support producing a JSON object of tags instead of a Rust code file.

parser/Cargo.toml -> chrono
scpproxy/Cargo.toml -> dicom-dictorionary-std
ul/Cargo.toml -> dicom-core

That can be done for the sake of simplifying the Cargo manifests, though the dependencies themselves are fetched transitively anyway.

Also 2 files are not used

transfer-syntax-registry/src/deflate.rs

I suggest that we revive #438 instead.

and

object/src/attribute.rs

Will take care of that in #524.

@Enet4 Enet4 force-pushed the chore/cargo-update-2024-12 branch from 57fef43 to de6d27f Compare December 7, 2024 13:03
@Enet4 Enet4 merged commit 477a797 into master Dec 7, 2024
5 checks passed
@Enet4 Enet4 deleted the chore/cargo-update-2024-12 branch December 7, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants