Tuan/homework 2 #30
Open
Tuan/homework 2 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 2, 2023 01:06
…VanTuan_BE-K01 into tuan/homework-2
…VanTuan_BE-K01 into tuan/homework-2
…VanTuan_BE-K01 into tuan/homework-2
tuanpham197
force-pushed
the
tuan/homework-2
branch
from
23b88d9
to
be0ccae
Compare
tpdongcs
reviewed
Jun 8, 2023
cmd/student-manager/main.go
Outdated
| // lock | ||
| fmt.Println("lock") | ||
| err := rd.SetNX(rd.Context(), keyApiPing, id, 5*time.Second).Err() | ||
| if err != nil { |
There was a problem hiding this comment.
can retry till you can get the lock
|
|
||
| fmt.Println("API /ping accessed") | ||
|
|
||
| err = rd.Close() |
There was a problem hiding this comment.
why need to close redis ?
cmd/student-manager/main.go
Outdated
| } | ||
| } | ||
|
|
||
| if count == 2 { |
There was a problem hiding this comment.
2 call/60s mean if count =2 then still ok, count > 2 then rate limited
There was a problem hiding this comment.
and usually we should check > but not = , because what happen if 2 people call this api at the same time ? then you will get response = 3, even 4 5 6, then you allow them to call this api right ? which is wrong
…VanTuan_BE-K01 into tuan/homework-2
tuanpham197
force-pushed
the
tuan/homework-2
branch
from
be0ccae
to
817ebf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.