-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete infrastructures for localizing tooltips/descriptions #5426
Merged
NielsPilgaard
merged 13 commits into
EnigmaticaModpacks:develop
from
ZZZank:even_more_locali
Nov 27, 2023
Merged
Complete infrastructures for localizing tooltips/descriptions #5426
NielsPilgaard
merged 13 commits into
EnigmaticaModpacks:develop
from
ZZZank:even_more_locali
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work again!
This reverts commit c9a1e89.
NielsPilgaard
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes every tooltips/descritions defined in scripts localizable. It's a continuation of #5423 .
Summary
and
%s
placeholder. It's first used in Simple Farming Beverages descriptionsNew Infrastructure
with
The new infrastructures added a
with
, which is in the same level ofitems
andtext
, to allow handling%s
intext
.with
should be a nested array. An real world example may look like this:This will be interpreted as:
Test
I don't have time to do a throughout test recently, but I do made a quick test, and no problem found.