fix #5379 #5437
Merged
fix #5379 #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe I should ask Niels to update Crowdin
|
I also hava a problem: When will Crowdin project gets update? |
|
Thanks for the contribution, I'll review within a day or two 👍
I've just synced, so it should be good now - Apparently it got stuck in December 2022 😅 |
NielsPilgaard
approved these changes
Jan 23, 2024
| @@ -10,7 +10,13 @@ onEvent('recipes', (event) => { | |||
| type: 'ITEM', | |||
| id: 'pneumaticcraft:reinforced_chest', | |||
| amount: 1, | |||
| nbt: `{display:{Name:'[{"text":"Atum Mineral Survey"}]',Lore:['[{"text":"A collection of minerals from Atum.","color":"gold"}]']},BlockEntityTag:{LootTable:"enigmatica:chests/amadron_mineral_survey_atum_combo"}}` | |||
| nbt: JSON.stringify({ | |||
|
Excellent PR as usual, thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, combined with my previous PRs(like #5435 ), fixes #5379 , with some additions.
This PR enables localizations for:
and
JSON.stringifyto generate nbt string, for a better formatfixes some wrong translations I made in Fluid registry rework #5435Switched to Crowdin