Gracefully handle ErrorKind::BrokenPipe (public-api ... | head -n 1)#94
Merged
Gracefully handle ErrorKind::BrokenPipe (public-api ... | head -n 1)#94
ErrorKind::BrokenPipe (public-api ... | head -n 1)#94Conversation
Owner
Author
|
Hmm maybe we should implement the fix with the Cons:
Pros:
For cargo-public-api I'd say it is fine to use the extra dependency. I'll think about it some more (and try it out) for public-api. |
So that we don't get an error when doing something like this:
% RUSTDOCFLAGS='-Z unstable-options --output-format json' cargo +nightly doc --manifest-path tests/crates/comprehensive_api/Cargo.toml --lib --no-deps
% ./target/debug/public-api tests/crates/comprehensive_api/target/doc/comprehensive_api.json | head -n 1
pub async fn comprehensive_api::functions::async_fn() -> impl Future<Output = ()>
Error: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }
fd429b9 to
df44eb8
Compare
Owner
Author
|
I found a way that I consider lightweight enough to not warrant an additional dependency. I will think about this for one more day and then merge. (rust-lang/rust#96647 was just approved so we will need to make a release any day now to keep working with latest nightly) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we don't get an error when doing something like this: